-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add The Ability to Disable Kebab Casing #58
Conversation
@inxilpro for some reason, the last 9 workflows are still pending. Not exactly sure why. I didn't know GitHub had different run groups for GHA. 🤷🏻♂️ |
OK. I reverted the whitespace changes, but now that I look the PR I have some concerns. Before I bring them up, though, what are you hoping to achieve with this? Do you prefer a different casing standard, other than kebab? Or do you actually have a scenario where you would like whatever is passed to the command? I think the better way to approach this would be to introduce a config variable that defaults to |
I updated the PR to allow for more naming configurations, but I'm not 100% sure you would want to do this… If you browse the first 10-15 pages of Packagist's most popular packages there isn't a single one that's camel- or studly-cased (and only a couple that are snake-case). |
For the purposes of external packages, yes, I'd agree that kebab case would more than likely be the go-to for package naming. However, the |
So, given a module called "Shopping Cart" and a company named "Galactic Empire" would your preference be:
? |
I think this is a much better solution than the one I submitted! |
Path: |
@inxilpro is there any movement on this? Is there anything I can do to help get this into a mergable state? |
This PR adds the ability for users of this package to disable kebab casing.