Skip to content

Commit

Permalink
chore(dev): remove yarn workspaces & update docs
Browse files Browse the repository at this point in the history
svelte does not work properly with hoisted modules (from yarn workspaces), see:
sveltejs/rollup-plugin-svelte#55
  • Loading branch information
Introvertuous committed Apr 5, 2020
1 parent 707e9a6 commit 7563d67
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 522 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ Click an icon to copy the import statement to your clipboard.

### Running The Example (Icon Navigator)

should be as simple as running `yarn` (at root) and then `yarn dev` (inside `/example`).
Should be as simple as running `yarn` and then `yarn dev` at root and at `/example` (second terminal).

[ NOTE / TODO ]: Building the example takes a very long time, but technically hot-reloading should be fast, although it seems that rollup is not caching dynamic imports for some reason, which means dev with hot-reload is not possible atm. The current work around is to remove some number (ideally all but one) of dynamic imports from inside `store.js`, depending on which packages you need during development.
6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"description": "Icon components for svelte",
"author": "Chris Ryan",
"license": "MIT",
"private": true,
"scripts": {
"travis-deploy-once": "travis-deploy-once",
"semantic-release": "semantic-release",
Expand Down Expand Up @@ -55,8 +54,5 @@
"commitizen": {
"path": "./node_modules/cz-conventional-changelog"
}
},
"workspaces": [
"example"
]
}
}
Loading

0 comments on commit 7563d67

Please sign in to comment.