refactors property data to avoid possible conflict #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomKovac
approved these changes
Feb 10, 2025
TomKovac
deleted the
588-bug-property-data-can-conflict-with-inherited-members-in-application
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on renaming the
Dataproperty toDataExchangeTwinObjectacross several classes and interfaces in theAXOpen.Datanamespace. The changes also include corresponding updates to the test files to reflect this renaming.Renaming of
DatatoDataExchangeTwinObject:src/data/src/AXOpen.Data/DataExchange/AxoDataExchange.cs: Renamed theDataproperty toDataExchangeTwinObjectand updated its documentation.src/data/src/AXOpen.Data/DataExchange/IAxoDataExchange.cs: Updated theDataproperty toDataExchangeTwinObjectwith appropriate documentation.src/data/src/AXOpen.Data/DataFragmentExchange/AxoDataFragmentExchange.cs:Dataproperty toDataExchangeTwinObjectand updated its documentation.DatatoDataExchangeTwinObjectin methods such asCreateDataFragments,SetLockedBy,ExistsAsync, etc. [1] [2] [3]Test Updates:
src/data/tests/AXOpen.Data.Tests/DataExchange/AxoDataExchangeTests.cs: Updated test cases to useDataExchangeTwinObjectinstead ofData.src/data/tests/AXOpen.Data.Tests/DataExchangeFragments/AxoDataFragmentExchange.cs: Modified multiple test methods to reflect the renaming of theDataproperty toDataExchangeTwinObject. [1] [2] [3] [4] [5] [6] [7] [8]src/integrations/tests/AXOpen.Integration.Data.Blazor.Tests/AxoDataViewModelTests.cs: Updated the test method to useDataExchangeTwinObject.closes #588