Nuke only interface type ec2 network (gruntwork-io#735)

Israelistic · Jul 8, 2024 · e3b5013 · e3b5013
1 parent aef8a3e
commit e3b5013
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/aws/resources/ec2_network_interface.go b/aws/resources/ec2_network_interface.go
@@ -47,6 +47,17 @@ func (ni *NetworkInterface) getAll(c context.Context, configObj config.Config) (
 			continue
 		}
 
+		// NOTE: Not all network interface types can be detached programmatically, and some may take longer to nuke.
+		// Interfaces attached to Lambda or other AWS services may have specific detachment mechanisms managed by
+		// those services. Attempting to detach these via the API can cause errors. Skipping non-interface types
+		// ensures they are cleaned up automatically upon service deletion.
+		if awsgo.StringValue(networkInterface.InterfaceType) != NetworkInterfaceTypeInterface {
+			logging.Debugf("[Skip] Can't detach network interface of type '%v' via API. "+
+				"Detachment for this type is managed by the dependent service and will occur automatically upon "+
+				"resource deletion.", awsgo.StringValue(networkInterface.InterfaceType))
+			continue
+		}
+
 		if shouldIncludeNetworkInterface(networkInterface, firstSeenTime, configObj) {
 			identifiers = append(identifiers, networkInterface.NetworkInterfaceId)
 		}

diff --git a/aws/resources/ec2_network_interface_test.go b/aws/resources/ec2_network_interface_test.go
@@ -72,6 +72,7 @@ func TestNetworkInterface_GetAll(t *testing.T) {
 				NetworkInterfaces: []*ec2.NetworkInterface{
 					{
 						NetworkInterfaceId: awsgo.String(testId1),
+						InterfaceType:      awsgo.String(NetworkInterfaceTypeInterface),
 						TagSet: []*ec2.Tag{
 							{
 								Key:   awsgo.String("Name"),
@@ -85,6 +86,7 @@ func TestNetworkInterface_GetAll(t *testing.T) {
 					},
 					{
 						NetworkInterfaceId: awsgo.String(testId2),
+						InterfaceType:      awsgo.String(NetworkInterfaceTypeInterface),
 						TagSet: []*ec2.Tag{
 							{
 								Key:   awsgo.String("Name"),
@@ -180,6 +182,7 @@ func TestNetworkInterface_NukeAll(t *testing.T) {
 				NetworkInterfaces: []*ec2.NetworkInterface{
 					{
 						NetworkInterfaceId: awsgo.String(testId1),
+						InterfaceType:      awsgo.String(NetworkInterfaceTypeInterface),
 						TagSet: []*ec2.Tag{
 							{
 								Key:   awsgo.String("Name"),
@@ -193,6 +196,7 @@ func TestNetworkInterface_NukeAll(t *testing.T) {
 					},
 					{
 						NetworkInterfaceId: awsgo.String(testId2),
+						InterfaceType:      awsgo.String(NetworkInterfaceTypeInterface),
 						TagSet: []*ec2.Tag{
 							{
 								Key:   awsgo.String("Name"),

diff --git a/aws/resources/ec2_network_interface_types.go b/aws/resources/ec2_network_interface_types.go
@@ -11,6 +11,10 @@ import (
 	"github.com/gruntwork-io/go-commons/errors"
 )
 
+const (
+	NetworkInterfaceTypeInterface = "interface"
+)
+
 type NetworkInterface struct {
 	BaseAwsResource
 	Client       ec2iface.EC2API