Skip to content

Commit

Permalink
PRs merely bumping protocol/game version numbers will henceforth be t…
Browse files Browse the repository at this point in the history
…reated as spam
  • Loading branch information
dktapps authored Oct 19, 2016
1 parent ce1fd04 commit c463255
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,15 @@ Channel rule: **Don't ask to ask, if anyone is here or alive, or uses something.
### Code Contributions

- **Avoid using GitHub Web Editor.** GitHub Web doesn't provide every Git feature, and using the web editor means you haven't tested the code. It's immediately obvious if you've used the Web editor, and if you do, your PR is likely to be rejected. Also **do not use a mobile device** for code editing.

- **Do not consider spamming pull requests.** If you don't know how to squash and force push, use [this site](https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request) to learn how.

- Test your changes before opening a pull request. **Do not submit a PR if the CI fails.**

- Make sure you can fully explain WHY and HOW your changes work. If you can't provide a full and comprehensive explanation as to why your changes work and what the effects are, do not submit a pull request.

- Use descriptive commit messages. See [an example](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) here.

- One change per commit. Squash redundant commits.

- Pull requests doing little things like bumping protocol numbers will be closed as spam. We don't need people spamming us with protocol numbers, especially when said people do not TEST things properly before making a PR. There is always a reason why the protocol VERSION NUMBER is changed - to reflect internal BACKWARDS-INCOMPATIBLE changes.

0 comments on commit c463255

Please sign in to comment.