Skip to content

Commit

Permalink
config: rename shadow-hex to shadow-color
Browse files Browse the repository at this point in the history
It's not directly clear from the name "shadow-hex" that it's related to
color.

Signed-off-by: Yuxuan Shui <[email protected]>
  • Loading branch information
yshui committed Aug 18, 2020
1 parent f99be82 commit 3ae21aa
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions man/picom.1.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ OPTIONS
*--write-pid-path* 'PATH'::
Write process ID to a file.

*--shadow-color* 'STRING'::
Color of shadow, as a hex string ('#000000')

*--shadow-red* 'VALUE'::
Red color value of shadow (0.0 - 1.0, defaults to 0).

Expand Down Expand Up @@ -151,9 +154,6 @@ OPTIONS
*--shadow-exclude* 'CONDITION'::
Specify a list of conditions of windows that should have no shadow.

*--shadow-hex* 'STRING'::
Color of shadow using hex string ('#000000')

*--fade-exclude* 'CONDITION'::
Specify a list of conditions of windows that should not be faded.

Expand Down
2 changes: 1 addition & 1 deletion picom.sample.conf
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ shadow-offset-y = -7;
# shadow-blue = 0

# Hex string color value of shadow (#000000 - #FFFFFF, defaults to #000000). This option will override options set shadow-(red/green/blue)
# shadow-hex = "#000000"
# shadow-color = "#000000"

# Do not paint shadows on shaped windows. Note shaped windows
# here means windows setting its shape through X Shape extension.
Expand Down
2 changes: 1 addition & 1 deletion src/config.c
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ char *parse_config(options_t *opt, const char *config_file, bool *shadow_enable,
.sw_opti = false,
.use_damage = true,

.shadow_hex = "#000000",
.shadow_color = "#000000",
.shadow_red = 0.0,
.shadow_green = 0.0,
.shadow_blue = 0.0,
Expand Down
2 changes: 1 addition & 1 deletion src/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ typedef struct options {
// === Shadow ===
/// Red, green and blue tone of the shadow.
double shadow_red, shadow_green, shadow_blue;
char *shadow_hex;
char *shadow_color;
int shadow_radius;
int shadow_offset_x, shadow_offset_y;
double shadow_opacity;
Expand Down
4 changes: 2 additions & 2 deletions src/config_libconfig.c
Original file line number Diff line number Diff line change
Expand Up @@ -425,8 +425,8 @@ char *parse_config_libconfig(options_t *opt, const char *config_file, bool *shad
config_lookup_float(&cfg, "shadow-green", &opt->shadow_green);
// --shadow-blue
config_lookup_float(&cfg, "shadow-blue", &opt->shadow_blue);
// --shadow-hex
if (config_lookup_string(&cfg, "shadow-hex", &sval)) {
// --shadow-color
if (config_lookup_string(&cfg, "shadow-color", &sval)) {
struct color rgb;
rgb = hex_to_rgb(sval);
opt->shadow_red = rgb.red;
Expand Down

0 comments on commit 3ae21aa

Please sign in to comment.