Enable pyrit to compile and run better on non-x86 machines #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently pyrit is not able to compile in non-x86 platforms due to the fact that instrinsic x86 parameters are being called, as -maes and -mpclmul.
These days, even when pyrit is running on a non x86 CPU, it shows the platform as x86. I just changed that to read the value from the getauxval(3) and print it, other than the hard coded x86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyrit is currently broken on non-x86 machines. It does even compile. These patches enable pyrit to build and run on non x86, as Power and ARM architecture.
This is the problem I am facing when compiling it on non-x86:
powerpc64le-linux-gnu-gcc: error: unrecognized command line option ‘-maes’
powerpc64le-linux-gnu-gcc: error: unrecognized command line option ‘-mpclmul’
This PR closes issue #488.