fix parseDateTimeBestEffortOrNull with empty string

JacobHayes · Oct 30, 2020 · f428675 · f428675
1 parent 19794be
commit f428675
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/src/IO/parseDateTimeBestEffort.cpp b/src/IO/parseDateTimeBestEffort.cpp
@@ -533,6 +533,10 @@ ReturnType parseDateTimeBestEffortImpl(
         }
     }
 
+    /// If neigher Date nor Time is parsed successfully, it should fail
+    if (!year && !month && !day_of_month && !has_time)
+        return on_error("Cannot read DateTime: neither Date nor Time was parsed successfully", ErrorCodes::CANNOT_PARSE_DATETIME);
+
     if (!year)
         year = 2000;
     if (!month)

diff --git a/tests/queries/0_stateless/01543_parse_datetime_besteffort_or_null_empty_string.reference b/tests/queries/0_stateless/01543_parse_datetime_besteffort_or_null_empty_string.reference
@@ -0,0 +1,8 @@
+2010-01-01 00:00:00
+2010-01-01 01:01:01
+2000-01-01 01:01:01
+\N
+\N
+\N
+\N
+\N
diff --git a/tests/queries/0_stateless/01543_parse_datetime_besteffort_or_null_empty_string.sql b/tests/queries/0_stateless/01543_parse_datetime_besteffort_or_null_empty_string.sql
@@ -0,0 +1,8 @@
+SELECT parseDateTimeBestEffortOrNull('2010-01-01');
+SELECT parseDateTimeBestEffortOrNull('2010-01-01 01:01:01');
+SELECT parseDateTimeBestEffortOrNull('01:01:01');
+SELECT parseDateTimeBestEffortOrNull('20100');
+SELECT parseDateTimeBestEffortOrNull('0100:0100:0000');
+SELECT parseDateTimeBestEffortOrNull('x');
+SELECT parseDateTimeBestEffortOrNull('');
+SELECT parseDateTimeBestEffortOrNull('       ');