refactor!: Rename skip_sign_extension to skip_extension_signing (c…

…ometbft#2522)

Follow-up and bikeshedding after cometbft#2519:

- Rename the added field to `skip_extension_signing` which reads better.
- Update the `tendermint.privval.SignVoteRequest` definition as per the
current practice.

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

.changelog/unreleased/improvements/2496-privval-ext-signature.md

@@ -1,4 +1,4 @@
 - `[privval]` DO NOT require extension signature from privval if vote
   extensions are disabled. Remote signers can skip signing the extension if
-  `skip_sign_extension` flag in `SignVoteRequest` is true.
+  `skip_extension_signing` flag in `SignVoteRequest` is true.
   [\#2496](https://github.com/cometbft/cometbft/pull/2496)

.changelog/unreleased/improvements/2522-privval-skip-extension-signing.md

@@ -0,0 +1,2 @@
+- `[proto]` Add `skip_extension_signing` field to the `SignVoteRequest` message
+  in privval ([\#2522](https://github.com/cometbft/cometbft/pull/2522))

privval/signer_client.go

@@ -93,7 +93,7 @@ func (sc *SignerClient) GetPubKey() (crypto.PubKey, error) {
 
 // SignVote requests a remote signer to sign a vote.
 func (sc *SignerClient) SignVote(chainID string, vote *cmtproto.Vote, signExtension bool) error {
-	response, err := sc.endpoint.SendRequest(mustWrapMsg(&pvproto.SignVoteRequest{Vote: vote, ChainId: chainID, SkipSignExtension: !signExtension}))
+	response, err := sc.endpoint.SendRequest(mustWrapMsg(&pvproto.SignVoteRequest{Vote: vote, ChainId: chainID, SkipExtensionSigning: !signExtension}))
 	if err != nil {
 		return err
 	}

privval/signer_requestHandler.go

@@ -62,7 +62,7 @@ func DefaultValidationRequestHandler(
 
 		vote := r.SignVoteRequest.Vote
 
-		err = privVal.SignVote(chainID, vote, !r.SignVoteRequest.SkipSignExtension)
+		err = privVal.SignVote(chainID, vote, !r.SignVoteRequest.SkipExtensionSigning)
 		if err != nil {
 			res = mustWrapMsg(&pvproto.SignedVoteResponse{
 				Vote: cmtproto.Vote{}, Error: &pvproto.RemoteSignerError{Code: 0, Description: err.Error()},

proto/cometbft/privval/v1/types.proto

@@ -26,9 +26,9 @@ message PubKeyResponse {
 
 // SignVoteRequest is a request to sign a vote
 message SignVoteRequest {
-  cometbft.types.v1.Vote vote           = 1;
-  string                 chain_id       = 2;
-  bool                   skip_sign_extension = 3; // if true, the signer may skip signing the extension bytes.
+  cometbft.types.v1.Vote vote                   = 1;
+  string                 chain_id               = 2;
+  bool                   skip_extension_signing = 3;  // if true, the signer may skip signing the extension bytes.
 }
 
 // SignedVoteResponse is a response containing a signed vote or an error

proto/tendermint/privval/types.proto

@@ -32,8 +32,9 @@ message PubKeyResponse {
 
 // SignVoteRequest is a request to sign a vote
 message SignVoteRequest {
-  tendermint.types.Vote vote     = 1;
-  string                chain_id = 2;
+  tendermint.types.Vote vote                   = 1;
+  string                chain_id               = 2;
+  bool                  skip_extension_signing = 3;  // if true, the signer may skip signing the extension bytes.
 }
 
 // SignedVoteResponse is a response containing a signed vote or an error