Skip to content

Commit

Permalink
Merge pull request presidentbeef#365 from presidentbeef/add_tracker_w…
Browse files Browse the repository at this point in the history
…arnings

Add Tracker#warnings to simplify warning access
  • Loading branch information
presidentbeef committed Jul 11, 2013
2 parents 72abb24 + 57f6f4f commit 37dfabd
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion bin/brakeman
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ begin
tracker = Brakeman.run options.merge(:print_report => true, :quiet => options[:quiet])

#Return error code if --exit-on-warn is used and warnings were found
if options[:exit_on_warn] and not tracker.checks.all_warnings.empty?
if options[:exit_on_warn] and not tracker.warnings.empty?
exit Brakeman::Warnings_Found_Exit_Code
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/brakeman/report/report_base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def warnings_summary
end

def all_warnings
@all_warnings ||= @checks.all_warnings
@all_warnings ||= @tracker.warnings
end

def number_of_templates tracker
Expand Down
4 changes: 4 additions & 0 deletions lib/brakeman/tracker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ def report
Brakeman::Report.new(@app_tree, self)
end

def warnings
self.checks.all_warnings
end

def index_call_sites
finder = Brakeman::FindAllCalls.new self

Expand Down
2 changes: 1 addition & 1 deletion test/tests/differ.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class DifferTests < Test::Unit::TestCase
include BrakemanTester::DiffHelper

def setup
@warnings = DiffRun.checks.all_warnings
@warnings = DiffRun.warnings
end

def diff new, old
Expand Down

0 comments on commit 37dfabd

Please sign in to comment.