Skip to content

Commit

Permalink
fix acceptance test (airbytehq#2912)
Browse files Browse the repository at this point in the history
  • Loading branch information
cgardens authored Apr 17, 2021
1 parent 1ae2cc2 commit 451aa97
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,6 @@ jobs:
GIT_REVISION: ${{ github.sha }}
CORE_ONLY: true

- name: Ensure no file change
run: git status --porcelain && test -z "$(git status --porcelain)"

- name: Run Docker End-to-End Acceptance Tests
run: |
./tools/bin/acceptance_test.sh
Expand Down Expand Up @@ -216,9 +213,6 @@ jobs:
# GIT_REVISION: ${{ github.sha }}
# CORE_ONLY: true
#
# - name: Ensure no file change
# run: git status --porcelain && test -z "$(git status --porcelain)"
#
# - name: Run Kubernetes End-to-End Acceptance Tests
# run: |
# ./tools/bin/acceptance_test_kube.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@
import io.airbyte.db.Databases;
import io.airbyte.test.utils.PostgreSQLContainerHelper;
import java.io.IOException;
import java.net.Inet4Address;
import java.net.UnknownHostException;
import java.nio.charset.Charset;
import java.sql.SQLException;
import java.time.Duration;
Expand Down Expand Up @@ -689,8 +687,11 @@ private JsonNode getDbConfig(PostgreSQLContainer psql, boolean hiddenPassword, b
try {
final Map<Object, Object> dbConfig = new HashMap<>();

// todo (cgardens) - hack to get building passing in CI. need to follow up on why this was necessary
// (and affect on the k8s version of these tests).
dbConfig.put("host", "localhost");
// necessary for minikube tests on Github Actions instead of psql.getHost()
dbConfig.put("host", Inet4Address.getLocalHost().getHostAddress());
// dbConfig.put("host", Inet4Address.getLocalHost().getHostAddress());

if (hiddenPassword) {
dbConfig.put("password", "**********");
Expand All @@ -711,7 +712,7 @@ private JsonNode getDbConfig(PostgreSQLContainer psql, boolean hiddenPassword, b
}

return Jsons.jsonNode(dbConfig);
} catch (UnknownHostException e) {
} catch (Exception e) {
throw new RuntimeException(e);
}
}
Expand Down

0 comments on commit 451aa97

Please sign in to comment.