Fix migrations (airbytehq#2406)

Jimao · Mar 11, 2021 · 55c0f9e · 55c0f9e
1 parent 134f60a
commit 55c0f9e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/airbyte-migration/src/main/java/io/airbyte/migrate/migrations/MigrationV0_17_0.java b/airbyte-migration/src/main/java/io/airbyte/migrate/migrations/MigrationV0_17_0.java
@@ -130,7 +130,7 @@ public void migrate(Map<ResourceId, Stream<JsonNode>> inputData, Map<ResourceId,
       final Consumer<JsonNode> recordConsumer = outputData.get(entry.getKey());
 
       entry.getValue().forEach(r -> {
-        if (!r.get("dockerImageTag").isNull()) {
+        if (r.get("dockerImageTag") != null) {
           if (entry.getKey().equals(STANDARD_SOURCE_DEFINITION_RESOURCE_ID)) {
             ((ObjectNode) r).set("dockerImageTag", getDockerImageTag(SOURCE_DOCKER_IMAGES, r));
           } else if (entry.getKey().equals(STANDARD_DESTINATION_DEFINITION_RESOURCE_ID)) {

diff --git a/airbyte-migration/src/test/java/io/airbyte/migrate/migrations/MigrateV0_17_0Test.java b/airbyte-migration/src/test/java/io/airbyte/migrate/migrations/MigrateV0_17_0Test.java
@@ -102,7 +102,7 @@ void testMigration() {
             Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(BIGQUERY_DESTINATION).put("dockerImageTag", "0.3.51").build()),
             Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(CUSTOM_DESTINATION).put("dockerImageTag", "0.1.42").build())),
         MigrationV0_17_0.STANDARD_SOURCE_DEFINITION_RESOURCE_ID, Stream.of(
-            Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(POSTGRES_SOURCE).put("dockerImageTag", "0.1.0").build()),
+            Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(POSTGRES_SOURCE).build()),
             Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(FILE_SOURCE).put("dockerImageTag", "My own custom version").build()),
             Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(CUSTOM_SOURCE).put("dockerImageTag", "dev").build()),
             Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(UNKNOWN_SOURCE).put("dockerImageTag", "0.1.0").build())));
@@ -116,7 +116,7 @@ void testMigration() {
             Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(BIGQUERY_DESTINATION).put("dockerImageTag", "0.3.51").build()),
             Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(CUSTOM_DESTINATION).put("dockerImageTag", "0.1.42").build())),
         MigrationV0_17_0.STANDARD_SOURCE_DEFINITION_RESOURCE_ID, ImmutableList.of(
-            Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(POSTGRES_SOURCE).put("dockerImageTag", "0.2.0").build()),
+            Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(POSTGRES_SOURCE).build()),
             Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(FILE_SOURCE).put("dockerImageTag", "My own custom version").build()),
             Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(CUSTOM_SOURCE).put("dockerImageTag", "dev").build()),
             Jsons.jsonNode(ImmutableMap.<String, String>builder().putAll(UNKNOWN_SOURCE).put("dockerImageTag", "0.1.0").build())));