forked from airbytehq/airbyte
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove seed generation task and seed from YAML files (airbytehq#5335)
## What - This is the first PR for airbytehq#4890. - This PR does not remove the config volume. - This PR does not mount the directories for the local connectors. - Resolves airbytehq#5373. ## How - Previously the seed container copies the configs to the storage root, it may take some time for the operation to complete and for the `CONFIG_DIR` to show up. So we cannot infer anything based on the existence of this directory. Now this seed generation step has been removed. So we can tell immediately whether `CONFIG_DIR` exists or not. - If `CONFIG_DIR` exists, it means the user has just migrated Airbyte from an old version that uses this file system config persistence. - Otherwise, we can seed the config persistence from the YAML files.
- Loading branch information
Showing
27 changed files
with
329 additions
and
495 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
107 changes: 0 additions & 107 deletions
107
airbyte-config/init/src/main/java/io/airbyte/config/init/SeedRepository.java
This file was deleted.
Oops, something went wrong.
49 changes: 49 additions & 0 deletions
49
airbyte-config/init/src/main/java/io/airbyte/config/init/SeedType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* MIT License | ||
* | ||
* Copyright (c) 2020 Airbyte | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in all | ||
* copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
* SOFTWARE. | ||
*/ | ||
|
||
package io.airbyte.config.init; | ||
|
||
public enum SeedType { | ||
|
||
STANDARD_SOURCE_DEFINITION("/seed/source_definitions.yaml", "sourceDefinitionId"), | ||
STANDARD_DESTINATION_DEFINITION("/seed/destination_definitions.yaml", "destinationDefinitionId"); | ||
|
||
final String resourcePath; | ||
// ID field name | ||
final String idName; | ||
|
||
SeedType(String resourcePath, String idName) { | ||
this.resourcePath = resourcePath; | ||
this.idName = idName; | ||
} | ||
|
||
public String getResourcePath() { | ||
return resourcePath; | ||
} | ||
|
||
public String getIdName() { | ||
return idName; | ||
} | ||
|
||
} |
127 changes: 0 additions & 127 deletions
127
airbyte-config/init/src/test/java/io/airbyte/config/init/SeedRepositoryTest.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.