peering_sharded_service: prevent over-run the container

The container pointer can be over run when using copy constructor or assignment operator. This patch removes those (and leave the default and move) to prevent unexpected results from users of the class. Signed-off-by: Amnon Heiman <[email protected]> Message-Id: <[email protected]>
JingSao · Aug 9, 2017 · cf55c9c · cf55c9c
1 parent 55a2c40
commit cf55c9c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/core/sharded.hh b/core/sharded.hh
@@ -57,11 +57,15 @@ protected:
 /// can call its peers.
 template <typename Service>
 class peering_sharded_service {
-    sharded<Service>* _container;
+    sharded<Service>* _container = nullptr;
 private:
     template <typename T> friend class sharded;
     void set_container(sharded<Service>* container) { _container = container; }
 public:
+    peering_sharded_service() = default;
+    peering_sharded_service(peering_sharded_service<Service>&&) = default;
+    peering_sharded_service(const peering_sharded_service<Service>&) = delete;
+    peering_sharded_service& operator=(const peering_sharded_service<Service>&) = delete;
     sharded<Service>& container() { return *_container; }
     const sharded<Service>& container() const { return *_container; }
 };