Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite update cycle bug fixed #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

v1996-96
Copy link

Infinite update cycle bug used to appear when I log into system, navigated between few pages, logged out and login with another user.
I am not able to show my code, but I can say that I did everything according to tutorial.
As I think, the problem could be lying into the sandboxGetter. So infinite cycle occurred on the perimeter computed property in the component, that uses multiple perimeters at once. Therefore for each perimeter in that component the new sandbox has been initialized. Within that process there could be created some links between sanboxes instances or they could be mutating each other and that could be causing infinity update loop.
So I have edited source code. Now the sandbox is being instantiated only once per component instantiation. That change fixed the problem I have had. But as I think, that change removed reactive link between sandbox and child getter (if there was one) :(

@v1996-96 v1996-96 mentioned this pull request Dec 20, 2017
@jayrchamp
Copy link

@v1996-96 I have had the infinite loop problem and your change have saved me some debug time. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants