[Regression]: Fix modal orders (All-Hands-AI#5779)

Co-authored-by: Graham Neubig <[email protected]>
JonathanCai · Dec 26, 2024 · 3bf5956 · 3bf5956
1 parent d86b536
commit 3bf5956
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/frontend/__tests__/routes/_oh.test.tsx b/frontend/__tests__/routes/_oh.test.tsx
@@ -40,7 +40,7 @@ describe("frontend/routes/_oh", () => {
     await screen.findByTestId("root-layout");
   });
 
-  it("should render the AI config modal if settings are not up-to-date", async () => {
+  it.skip("should render the AI config modal if settings are not up-to-date", async () => {
     settingsAreUpToDateMock.mockReturnValue(false);
     renderWithProviders(<RouteStub />);
 

diff --git a/frontend/src/routes/_oh/route.tsx b/frontend/src/routes/_oh/route.tsx
@@ -9,7 +9,6 @@ import { useConfig } from "#/hooks/query/use-config";
 import { Sidebar } from "#/components/features/sidebar/sidebar";
 import { WaitlistModal } from "#/components/features/waitlist/waitlist-modal";
 import { AnalyticsConsentFormModal } from "#/components/features/analytics/analytics-consent-form-modal";
-import { SettingsModal } from "#/components/shared/modals/settings/settings-modal";
 
 export function ErrorBoundary() {
   const error = useRouteError();
@@ -45,15 +44,12 @@ export function ErrorBoundary() {
 
 export default function MainApp() {
   const { gitHubToken } = useAuth();
-  const { settings, settingsAreUpToDate } = useSettings();
+  const { settings } = useSettings();
 
   const [consentFormIsOpen, setConsentFormIsOpen] = React.useState(
     !localStorage.getItem("analytics-consent"),
   );
 
-  const [aiConfigModalIsOpen, setAiConfigModalIsOpen] =
-    React.useState(!settingsAreUpToDate);
-
   const config = useConfig();
   const { data: isAuthed, isFetching: isFetchingAuth } = useIsAuthed();
 
@@ -92,13 +88,6 @@ export default function MainApp() {
           onClose={() => setConsentFormIsOpen(false)}
         />
       )}
-
-      {aiConfigModalIsOpen && (
-        <SettingsModal
-          onClose={() => setAiConfigModalIsOpen(false)}
-          data-testid="ai-config-modal"
-        />
-      )}
     </div>
   );
 }