Skip to content

Commit

Permalink
Merge pull request swiftlang#28432 from atrick/disable-unknown-storage
Browse files Browse the repository at this point in the history
Temporarily disable a SILVerifier check for valid accessed storage.
  • Loading branch information
atrick authored Nov 22, 2019
2 parents 83f9a52 + 32254de commit be1d896
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions lib/SIL/SILVerifier.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1886,8 +1886,15 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
// like debugger variables. The compiler never cares about the source of
// those accesses.
AccessedStorage storage = findAccessedStorage(BAI->getSource());
// FIXME: rdar://57291811 - the following check for valid storage will be
// reenabled shortly. A fix is planned. In the meantime, the possiblity that
// a real miscompilation could be caused by this failure is insignificant.
// I will probably enable a much broader SILVerification of address-type
// block arguments first to ensure we never hit this check again.
/*
if (BAI->getEnforcement() != SILAccessEnforcement::Unsafe)
require(storage, "Unknown formal access pattern");
*/
}

void checkEndAccessInst(EndAccessInst *EAI) {
Expand Down

0 comments on commit be1d896

Please sign in to comment.