Skip to content

Unit test #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Unit test #41

wants to merge 3 commits into from

Conversation

Hdebbech
Copy link
Contributor

These test cases will cover 92 % of the code base.

it helped detect some Bugs, I will open the found issues:

  1. the title of the number annotation is ignored and not found in the json schema
  2. the "readOnly" attribute is sometimes written "readonly" and other times "readOnly", maybe we need to define constants.

Copy link
Member

@SaifJerbi SaifJerbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @Hdebbech, you are doing 🎨
We have a build problem. It"s a compilation error, please try to fix this issue before i merge your code,

@Hdebbech
Copy link
Contributor Author

All test cases are failing, they were running fine in my local repo, I am closing this pull request, i will update with the latest changes and check them again.

@Hdebbech Hdebbech closed this Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants