Skip to content

Create SimpleFactory to remove some duplication between existing fact… #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
package io.asfjava.ui.core;

import java.util.Map;
import java.util.Optional;
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Supplier;

import io.asfjava.ui.core.generators.FormDefinitionGenerator;

public final class FormDefinitionGeneratorFactory {
public final class FormDefinitionGeneratorFactory extends SimpleFactory<String, FormDefinitionGenerator> {

private static FormDefinitionGeneratorFactory instance;

Expand All @@ -17,15 +12,5 @@ public static FormDefinitionGeneratorFactory getInstance() {
: instance;
}

private final Map<String, FormDefinitionGenerator> generators = new ConcurrentHashMap<>();

private FormDefinitionGeneratorFactory() {}

public Optional<FormDefinitionGenerator> getGenerator(String annotationName) {
return Optional.ofNullable(generators.get(annotationName));
}

void register(Supplier<String> annotationName, FormDefinitionGenerator generator) {
generators.put(annotationName.get(), generator);
}
}
17 changes: 1 addition & 16 deletions src/main/java/io/asfjava/ui/core/SchemaDecoratorFactory.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,7 @@

import io.asfjava.ui.core.schema.decorators.SchemaDecorator;

import java.util.Map;
import java.util.Optional;
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Supplier;

public final class SchemaDecoratorFactory {
public final class SchemaDecoratorFactory extends SimpleFactory<String, SchemaDecorator> {

private static SchemaDecoratorFactory instance;

Expand All @@ -17,15 +12,5 @@ public static SchemaDecoratorFactory getInstance() {
: instance;
}

private final Map<String, SchemaDecorator> decorators = new ConcurrentHashMap<>();

private SchemaDecoratorFactory() {}

public Optional<SchemaDecorator> getDecorator(String annotationName) {
return Optional.ofNullable(decorators.get(annotationName));
}

void register(Supplier<String> annotationName, SchemaDecorator generator) {
decorators.put(annotationName.get(), generator);
}
}
19 changes: 19 additions & 0 deletions src/main/java/io/asfjava/ui/core/SimpleFactory.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package io.asfjava.ui.core;

import java.util.Map;
import java.util.Optional;
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Supplier;

public abstract class SimpleFactory<K, V> {

private final Map<K, V> map = new ConcurrentHashMap<>();

public Optional<V> get(K key) {
return Optional.ofNullable(map.get(key));
}

void register(Supplier<K> key, V value) {
map.put(key.get(), value);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ final class SchemaDecoratorUtil {
void decorate(BeanProperty beanProperty, JsonSchema simpleTypeSchema) {
Iterable<Annotation> it = beanProperty.getMember().annotations();
it.forEach(
annotation -> SchemaDecoratorFactory.getInstance().getDecorator(annotation.annotationType().getName())
annotation -> SchemaDecoratorFactory.getInstance().get(annotation.annotationType().getName())
.ifPresent(decorator -> decorator.customizeSchema(beanProperty, simpleTypeSchema)));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ private void buildFormDefinition(Map<Field, JsonNode> nodes, ObjectMapper mapper
private void buildFieldDefinition(Field field, Annotation annotation, ObjectMapper mapper,
Map<Field, JsonNode> nodes) {
ObjectNode fieldFormDefinition = mapper.createObjectNode();
FormDefinitionGeneratorFactory.getInstance().getGenerator(annotation.annotationType().getName())
FormDefinitionGeneratorFactory.getInstance().get(annotation.annotationType().getName())
.ifPresent(generator -> {
generator.generate(fieldFormDefinition, field);
nodes.put(field, fieldFormDefinition);
Expand Down