Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback #122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Callback #122

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a18c7d3
little refactor
bramtayl Oct 18, 2022
987d284
fix messenger eltype
bramtayl Oct 18, 2022
494d7c8
callback
bramtayl Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix messenger eltype
  • Loading branch information
@bramtayl
bramtayl committed Oct 18, 2022
commit 987d2840da57e9cc21215c65f3279ae51ebe04b8
5 changes: 2 additions & 3 deletions src/PortAudio.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ struct Messenger{Sample, Scribe, Input, Output}
output_channel::Channel{Output}
end

eltype(::Type{Messenger{Sample}}) where {Sample} = Sample
eltype(::Type{<: Messenger{Sample}}) where {Sample} = Sample
name(messenger::Messenger) = messenger.device_name
nchannels(messenger::Messenger) = nchannels(messenger.buffer)

Expand Down Expand Up @@ -535,9 +535,8 @@ function fetch_messenger(messenger, task)
# wait for tasks to finish to make sure any errors get caught
wait(task)
# output channel will close because it is bound to the task
else
""
end
nothing
end

#
Expand Down