Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Setfield compat #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simeonschaub
Copy link

@tkf Would it be possible to tag a new release with this right away?

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.97%. Comparing base (02a3a26) to head (de9dc91).

❗ There is a different number of reports uploaded between BASE (02a3a26) and HEAD (de9dc91). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (02a3a26) HEAD (de9dc91)
unittests 5 4
1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #38       +/-   ##
===========================================
- Coverage   69.23%   50.97%   -18.26%     
===========================================
  Files           6        6               
  Lines         221      206       -15     
===========================================
- Hits          153      105       -48     
- Misses         68      101       +33     
Flag Coverage Δ
unittests 50.97% <ø> (-3.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

simeonschaub added a commit to JuliaLabs/AztecDiamonds.jl that referenced this pull request Jan 24, 2023
need to support MakieCore 0.5 until
JuliaFolds/UnionArrays.jl#38 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant