Remove Grisu for Ryu; #29
Conversation
| @@ -36,8 +28,9 @@ end | |||
| @test Showoff.format_fixed_scientific(-Inf, 1, false) == "-∞" | |||
| @test Showoff.format_fixed_scientific(NaN, 1, false) == "NaN" | |||
| @test Showoff.format_fixed_scientific(0.012345678, 4, true) == "12.34568×10⁻³" | |||
| @test Showoff.format_fixed_scientific(0.012345678, 4, false) == "1.234568×10⁻²" | |||
| @test Showoff.format_fixed_scientific(-10.0, 4, false) == "-1.000×10¹" | |||
| @test Showoff.format_fixed_scientific(0.012345678, 4, false) == "1.2346×10⁻²" | |||
There was a problem hiding this comment.
This test is modified as in the function docstring it says that (line 140 in the original code) the function should match @printf.
| @@ -36,8 +28,9 @@ end | |||
| @test Showoff.format_fixed_scientific(-Inf, 1, false) == "-∞" | |||
| @test Showoff.format_fixed_scientific(NaN, 1, false) == "NaN" | |||
| @test Showoff.format_fixed_scientific(0.012345678, 4, true) == "12.34568×10⁻³" | |||
There was a problem hiding this comment.
This test is failing, as I have still not implemented the engineering flag. Once the rest is approved, I will make sure this test passes, too.
| @test Showoff.format_fixed_scientific(-10.0, 4, false) == "-1.000×10¹" | ||
| @test Showoff.format_fixed_scientific(0.012345678, 4, false) == "1.2346×10⁻²" | ||
| @test Showoff.format_fixed_scientific(-10.0, 4, false) == "-1.0000×10¹" | ||
| @test Showoff.format_fixed_scientific(-2.99999999999999956E-16, 2, false) == "-3.00×10⁻¹⁶" |
There was a problem hiding this comment.
This is a new test, the loingstanding issue #22
|
I just pushed a branch, |
|
I did mention the existence of that branch in #28 (comment) |
|
Right I just realized it. I'll see if I can get it to work. Surprisingly the code you wrote is almost the same I have here. |
|
Indeed! The hard part is supporting the engineering notation; I tried to come up with a cheap trick, like multiplying or dividing by 10 to get it to the nearest multiple of 3, but then you end up doing carries on the |
There have been a few modification in tests too, details explained in the review