Handle isapprox 0 differently #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for reporting, perhaps you could also let people know in discourse that this has been solved |
|
Thanks! I would love to say that on the Discourse, but this merge hasn't solved the original problem. The original problem was caused by a change in Grisu and Gadfly being pinned to Showoff 0.3. I don't think that Plots.jl had any problems because they are already on Showoff 1.0 for a while, but I need to further investigate that. Anyway, could you register a new version of Showoff? Then, I'll ensure that Gadfly does so too. Then both Plots.jl and Gadfly.jl are based on the same version of Showoff, and it will probably be much easier to track down issues 😄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix #40.