Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reexport compat to 1.0 #30

Merged
merged 3 commits into from
May 19, 2021
Merged

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented May 18, 2021

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #30 (1975783) into master (7797652) will decrease coverage by 1.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   70.50%   69.00%   -1.51%     
==========================================
  Files          45       42       -3     
  Lines        1197     1168      -29     
==========================================
- Hits          844      806      -38     
- Misses        353      362       +9     
Impacted Files Coverage Δ
src/utils.jl 53.84% <0.00%> (-40.28%) ⬇️
src/ObjectFile.jl 100.00% <0.00%> (ø)
src/COFF/COFF.jl
src/MachO/MachO.jl
src/ELF/ELF.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7797652...1975783. Read the comment docs.

@giordano
Copy link
Member

This is checking out the manifest, which fixes Reexport to 0.2, so we aren't actually testing the new version

@IanButterworth
Copy link
Member Author

@staticfloat 1 tedious reapproval of CI runs please

test/Project.toml Outdated Show resolved Hide resolved
@staticfloat staticfloat merged commit c1c705c into JuliaIO:master May 19, 2021
@IanButterworth IanButterworth deleted the patch-1 branch May 19, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants