Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds drawtol to include a draw tolerance between solvers #53

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

lrsantos11
Copy link
Contributor

PR according to #52.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #53 (fbb3474) into master (61bdbd5) will increase coverage by 0.19%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   93.68%   93.87%   +0.19%     
==========================================
  Files           3        3              
  Lines          95       98       +3     
==========================================
+ Hits           89       92       +3     
  Misses          6        6              
Impacted Files Coverage Δ
src/performance_profiles.jl 91.93% <85.71%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61bdbd5...fbb3474. Read the comment docs.

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've made a few comments. Also, can you upload an example of the difference of drawtol = 0 and a small positive drawtol, like 0.01?

src/performance_profiles.jl Outdated Show resolved Hide resolved
src/performance_profiles.jl Outdated Show resolved Hide resolved
src/performance_profiles.jl Outdated Show resolved Hide resolved
@abelsiqueira abelsiqueira requested a review from dpo April 7, 2021 17:56
@lrsantos11
Copy link
Contributor Author

Also, can you upload an example of the difference of drawtol = 0 and a small positive drawtol, like 0.01?

Here they are. I used drawtol = 0.1.

Solvers
Solvers_Draw10percent

Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Thanks!

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks.

@abelsiqueira abelsiqueira changed the title adds drawtol to include a draw tolerance between solvers Adds drawtol to include a draw tolerance between solvers Apr 7, 2021
@abelsiqueira abelsiqueira merged commit cf12102 into JuliaSmoothOptimizers:master Apr 7, 2021
@lrsantos11 lrsantos11 deleted the drawtol branch April 7, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants