-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds drawtol
to include a draw tolerance between solvers
#53
Conversation
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 93.68% 93.87% +0.19%
==========================================
Files 3 3
Lines 95 98 +3
==========================================
+ Hits 89 92 +3
Misses 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I've made a few comments. Also, can you upload an example of the difference of drawtol = 0
and a small positive drawtol
, like 0.01
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! Thanks!
Co-authored-by: Abel Siqueira <[email protected]>
Co-authored-by: Abel Siqueira <[email protected]>
Co-authored-by: Abel Siqueira <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great, thanks.
drawtol
to include a draw tolerance between solversdrawtol
to include a draw tolerance between solvers
PR according to #52.