Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional orbital parameters to sim UI #2473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add additional orbital parameters to sim UI
  • Loading branch information
siimav committed Jan 5, 2025
commit d401e65ee3141af56a06a8eb3305d4941c8085d6
2 changes: 1 addition & 1 deletion Source/RP0/SpaceCenter/SimulationParams.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public CelestialBody SimulationBody
public bool SimulateInOrbit, DisableFailures;
public bool IsVesselMoved;
[Persistent]
public double SimulationUT, SimOrbitAltitude, SimInclination;
public double SimulationUT, SimOrbitAltitude, SimOrbitPe, SimOrbitAp, SimInclination, SimLAN;
[Persistent]
public int DelayMoveSeconds;

Expand Down
22 changes: 20 additions & 2 deletions Source/RP0/SpaceCenter/SpaceCenterManagement.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1286,8 +1286,26 @@ private void ProcessSimulation()
private static IEnumerator SetSimOrbit(SimulationParams simParams)
{
yield return new WaitForEndOfFrame();
RP0Debug.Log($"Moving vessel to orbit. {simParams.SimulationBody.bodyName}:{simParams.SimOrbitAltitude}:{simParams.SimInclination}");
HyperEdit_Utilities.PutInOrbitAround(simParams.SimulationBody, simParams.SimOrbitAltitude, simParams.SimInclination);

CelestialBody body = simParams.SimulationBody;
if (simParams.SimOrbitAp == 0 && simParams.SimOrbitPe == 0)
{
double sma = simParams.SimOrbitAltitude + body.Radius;
double ecc = 0.0000001; // Just a really smol value to prevent Ap and Pe from flickering around
RP0Debug.Log($"Moving vessel to orbit. {body.bodyName}:{simParams.SimOrbitAltitude}:{simParams.SimInclination}");
FlightGlobals.fetch.SetShipOrbit(body.flightGlobalsIndex, ecc, sma, simParams.SimInclination, simParams.SimLAN, 0.0, 0.0, 0.0);
FloatingOrigin.ResetTerrainShaderOffset();
}
else
{
double ra = simParams.SimOrbitAp + body.Radius;
double rp = simParams.SimOrbitPe + body.Radius;
double sma = (ra + rp) / 2;
double ecc = (ra - rp) / (ra + rp);
RP0Debug.Log($"Moving vessel to orbit. {body.bodyName}:{simParams.SimOrbitPe}/{simParams.SimOrbitAp}:{simParams.SimInclination}");
FlightGlobals.fetch.SetShipOrbit(body.flightGlobalsIndex, ecc, sma, simParams.SimInclination, simParams.SimLAN, Math.PI, 0.0, 0.0);
FloatingOrigin.ResetTerrainShaderOffset();
}
}

private void AddSimulationWatermark()
Expand Down
84 changes: 70 additions & 14 deletions Source/RP0/UI/KCT/GUI_Simulation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ public static partial class KCT_GUI
private static Rect _simulationConfigPosition = new Rect((Screen.width / 2) - 150, (Screen.height / 4), 300, 1);
private static Vector2 _bodyChooserScrollPos;

private static string _sOrbitAlt = "", _sOrbitInc = "", _UTString = "", _sDelay = "0";
private static string _sOrbitAlt = "", _sOrbitPe = "", _sOrbitAp = "", _sOrbitInc = "", _sOrbitLAN = "", _UTString = "", _sDelay = "0";
private static bool _fromCurrentUT = true;
private static bool _circOrbit = true;

public static void DrawSimulationWindow(int windowID)
{
Expand Down Expand Up @@ -72,20 +73,35 @@ public static void DrawSimulationConfigure(int windowID)
if (simParams.SimulationBody == Planetarium.fetch.Home)
{
bool changed = simParams.SimulateInOrbit;
simParams.SimulateInOrbit = GUILayout.Toggle(simParams.SimulateInOrbit, " Start in orbit?");
simParams.SimulateInOrbit = GUILayout.Toggle(simParams.SimulateInOrbit, " Start in orbit");
if (simParams.SimulateInOrbit != changed)
_simulationConfigPosition.height = 1;
}
if (simParams.SimulationBody != Planetarium.fetch.Home || simParams.SimulateInOrbit)
{
GUILayout.BeginHorizontal();
GUILayout.Label("Orbit Altitude (km): ");
_sOrbitAlt = GUILayout.TextField(_sOrbitAlt, GUILayout.Width(100));
GUILayout.EndHorizontal();
GUILayout.BeginHorizontal();
GUILayout.Label("Min: " + simParams.SimulationBody.atmosphereDepth / 1000);
GUILayout.Label("Max: " + Math.Floor(simParams.SimulationBody.sphereOfInfluence) / 1000);
GUILayout.EndHorizontal();
_circOrbit = GUILayout.Toggle(_circOrbit, "Circular");
if (_circOrbit)
{
GUILayout.BeginHorizontal();
GUILayout.Label("Orbit Altitude (km): ");
_sOrbitAlt = GUILayout.TextField(_sOrbitAlt, GUILayout.Width(100));
GUILayout.EndHorizontal();
GUILayout.BeginHorizontal();
GUILayout.Label("Min: " + simParams.SimulationBody.atmosphereDepth / 1000);
GUILayout.Label("Max: " + Math.Floor((simParams.SimulationBody.sphereOfInfluence - simParams.SimulationBody.Radius) / 1000));
GUILayout.EndHorizontal();
}
else
{
GUILayout.BeginHorizontal();
GUILayout.Label("Orbit Periapsis (km): ");
_sOrbitPe = GUILayout.TextField(_sOrbitPe, GUILayout.Width(100));
GUILayout.EndHorizontal();
GUILayout.BeginHorizontal();
GUILayout.Label("Orbit Apoapsis (km): ");
_sOrbitAp = GUILayout.TextField(_sOrbitAp, GUILayout.Width(100));
GUILayout.EndHorizontal();
}

if (!simParams.SimulateInOrbit) simParams.SimulateInOrbit = true;
}
Expand All @@ -101,6 +117,11 @@ public static void DrawSimulationConfigure(int windowID)
GUILayout.Label("Inclination: ");
_sOrbitInc = GUILayout.TextField(_sOrbitInc, GUILayout.Width(50));
GUILayout.EndHorizontal();

GUILayout.BeginHorizontal();
GUILayout.Label("LAN: ");
_sOrbitLAN = GUILayout.TextField(_sOrbitLAN, GUILayout.Width(50));
GUILayout.EndHorizontal();
}

GUILayout.Space(4);
Expand Down Expand Up @@ -174,20 +195,45 @@ private static void StartSim(SimulationParams simParams)
return;
}

if (simParams.SimulationBody != Planetarium.fetch.Home)
CelestialBody body = simParams.SimulationBody;

if (body != Planetarium.fetch.Home)
simParams.SimulateInOrbit = true;

if (simParams.SimulateInOrbit)
{
if (!double.TryParse(_sOrbitAlt, out simParams.SimOrbitAltitude))
simParams.SimOrbitAltitude = simParams.SimulationBody.atmosphere ? simParams.SimulationBody.atmosphereDepth + 20000 : 20000;
if (_circOrbit)
{
if (!double.TryParse(_sOrbitAlt, out simParams.SimOrbitAltitude))
simParams.SimOrbitAltitude = GetDefaultAltitudeForBody(body);
else
simParams.SimOrbitAltitude = EnsureSafeMaxAltitude(1000 * simParams.SimOrbitAltitude, body);

simParams.SimOrbitPe = simParams.SimOrbitAp = 0;
}
else
simParams.SimOrbitAltitude = Math.Min(Math.Max(1000 * simParams.SimOrbitAltitude, simParams.SimulationBody.atmosphereDepth), simParams.SimulationBody.sphereOfInfluence);
{
if (!double.TryParse(_sOrbitPe, out simParams.SimOrbitPe))
simParams.SimOrbitPe = GetDefaultAltitudeForBody(body);

if (!double.TryParse(_sOrbitAp, out simParams.SimOrbitAp))
simParams.SimOrbitAp = GetDefaultAltitudeForBody(body);

simParams.SimOrbitAp = EnsureSafeMaxAltitude(1000 * simParams.SimOrbitAp, body);
simParams.SimOrbitPe = Math.Min(1000 * simParams.SimOrbitPe, simParams.SimOrbitAp);

simParams.SimOrbitAltitude = 0;
}

if (!double.TryParse(_sOrbitInc, out simParams.SimInclination))
simParams.SimInclination = 0;
else
simParams.SimInclination %= 360;

if (!double.TryParse(_sOrbitLAN, out simParams.SimLAN))
simParams.SimLAN = 0;
else
simParams.SimLAN %= 360;
}

double currentUT = Planetarium.GetUniversalTime();
Expand Down Expand Up @@ -256,5 +302,15 @@ private static void StartSim(SimulationParams simParams)
FlightDriver.StartWithNewLaunch(tempFile, EditorLogic.FlagURL, launchSiteName, manifest);
}));
}

private static double EnsureSafeMaxAltitude(double altitudeMeters, CelestialBody body)
{
return Math.Min(Math.Max(altitudeMeters, body.atmosphereDepth), body.sphereOfInfluence - body.Radius - 1000);
}

private static double GetDefaultAltitudeForBody(CelestialBody body)
{
return body.atmosphere ? body.atmosphereDepth + 20000 : 20000;
}
}
}
Loading