Fix #9

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.4.1 (2022-01-20)
+
+### Bug fixes
+- Testing rules #9 (required [ElastAlert2 Server](https://github.com/Karql/elastalert2-server) in version >=5.0.0-next.4) 
+
 ## 1.4.0 (2021-03-16)
 
 ### Features

dev/dev-env/docker-compose.yml

@@ -23,7 +23,7 @@ services:
 
   # https://github.com/Karql/elastalert fork of bitsensor/elastalert
   elastalert:
-    image: karql/elastalert2-server:5.0.0-next.2
+    image: karql/elastalert2-server:5.0.0-next.4
     restart: always
     expose:
       - 3030
@@ -38,4 +38,4 @@ services:
       - ./conf/elastalert/rule_templates:/opt/elastalert/rule_templates
       - ./rules:/opt/elastalert/rules
     links:
-      - "elasticsearch" 
+      - "elasticsearch"

dev/test-env/docker-compose.yml

@@ -23,7 +23,7 @@ services:
 
   # https://github.com/Karql/elastalert fork of bitsensor/elastalert
   elastalert:
-    image: karql/elastalert2-server:5.0.0-next.2
+    image: karql/elastalert2-server:5.0.0-next.4
     restart: always
     expose:
       - 3030

package.json

@@ -1,6 +1,6 @@
 {
   "name": "elastalert-kibana-plugin",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "author": {
     "name": "Mateusz Karkula",
     "email": "[email protected]",

public/components/console/console.tsx

@@ -1,14 +1,15 @@
 import React from 'react';
 import { EuiCallOut } from '@elastic/eui';
 
-export const Console = (hasError: boolean, consoleOutput: any) => (
+export const Console = (props: { hasError: boolean, consoleOutput: string }) => (
   <EuiCallOut
     size="s"
     title="Console output"
     iconType="console"
-    color={hasError ? 'danger' : 'success'}
+    color={props.hasError ? 'danger' : 'success'}
     style={{ whiteSpace: 'pre-wrap' }}
+
   >
-    {consoleOutput}
+    {props.consoleOutput}
   </EuiCallOut>
 );

public/components/rules/editor/editor.tsx

@@ -83,8 +83,8 @@ export default class Editor extends Component {
         body: JSON.stringify({
           rule: this.state.value,
           options: {
-            testType: 'schemaOnly'
-          }          
+            testType: 'all'
+          }
         })
       })
       .then(resp => {
@@ -95,15 +95,16 @@ export default class Editor extends Component {
         });
       })
       .catch(e => {
+        let body = e.body;
         this.setState({
           testing: false,
           testFailed: true,
-          testResponse: e.message ? e.message : e,
+          testResponse: body.message ? body.message : body,
         });
       });
   };
 
-  onChange = value => {    
+  onChange = value => {
     this.setState({ value: value });
   };
 
@@ -158,7 +159,7 @@ export default class Editor extends Component {
                 }}
               />
               <EuiSpacer size="m" />
-              {this.state.testResponse && (
+              {this.state.testResponse !== null && (
                 <Console
                   hasError={this.state.testFailed}
                   consoleOutput={this.state.testResponse}

server/routes/index.ts

@@ -6,7 +6,7 @@ import { ConfigType } from '../config';
 import fetch from 'node-fetch';
 
 interface RegisterRoutesParams {
-  config$: Observable<ConfigType>;  
+  config$: Observable<ConfigType>;
   logger: Logger;
   router: IRouter;
 }
@@ -41,7 +41,7 @@ export const registerRoutes = (options: RegisterRoutesParams) => {
         },
         body: JSON.stringify(req.body),
       };
-      
+
       const postRequest = async () => {
         let url = (await getElastAlertServerUrl()) + `/rules/${req.params.ruleID}`;
         logger.debug(`POST ${url}`);
@@ -54,6 +54,7 @@ export const registerRoutes = (options: RegisterRoutesParams) => {
       };
 
       const result = await postRequest();
+
       return response.ok({
         body: {
           data: result,
@@ -83,21 +84,21 @@ export const registerRoutes = (options: RegisterRoutesParams) => {
         },
         body: JSON.stringify(req.body),
       };
-      
+
       const postRequest = async () => {
         let url = (await getElastAlertServerUrl()) + `/test`;
         logger.debug(`POST ${url}`);
-        return fetch(url, postParams);          
+        return fetch(url, postParams);
       };
 
       const result = await postRequest();
-      return response.ok({
-        body: {
-          data: result,
-        },
+
+      return response.custom({
+        statusCode: result.status,
+        body: result.body
       });
     }
-  );  
+  );
 
   router.get(
     {
@@ -122,7 +123,7 @@ export const registerRoutes = (options: RegisterRoutesParams) => {
     }
   );
 
-  router.delete( 
+  router.delete(
     {
       path: '/api/elastalert/rules/{ruleID}',
       validate: {