Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore uninitialized #61

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ignore uninitialized #61

wants to merge 4 commits into from

Conversation

Kentzo
Copy link
Owner

@Kentzo Kentzo commented Nov 7, 2018

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #61 into master will decrease coverage by 18.24%.
The diff coverage is 61.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #61       +/-   ##
===========================================
- Coverage   58.29%   40.04%   -18.25%     
===========================================
  Files           1        1               
  Lines         211      427      +216     
  Branches       41       68       +27     
===========================================
+ Hits          123      171       +48     
- Misses         71      230      +159     
- Partials       17       26        +9
Impacted Files Coverage Δ
git_archive_all.py 40.04% <61.45%> (-18.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57d7b2...86c0e6a. Read the comment docs.

--no-exclude -> --ignore-gitattributes
--extra -> --include

--include should properly recognize directories.

Refs #60
@akien-mga
Copy link

akien-mga commented Dec 12, 2018

I finally got to testing this PR. It doesn't seem to work as I would expect it with --ignore-uninitialized-submodules:

$ git clone https://github.com/hrydgard/ppsspp
$ cd ppsspp
$ git checkout v1.7.5
$ git submodule update --init --recursive assets/lang ext/SPIRV-Cross ext/armips ext/discord-rpc ext/glslang
$ git submodule 
 7ea29e4e90e01b2eabd303236fa5872bf3706ae0 assets/lang (7ea29e4)
-7751cf73f5c06f1be21f5f31c3e2d9a7bacd3a93 dx9sdk
 be7425ef70231ab82930331959ab487d605d0482 ext/SPIRV-Cross (2018-08-07~7)
 9efe3367284d2d1eeb14fc302a2c12c36e3e255e ext/armips (v0.9-128-g9efe336)
 3d3ae7129d17643bc706da0a2eea85aafd10ab3a ext/discord-rpc (v3.1.0-20-g3d3ae71)
 29619b2312f7bc862221749f3f4d37c3e6a0dee2 ext/glslang (2.3-2139-g29619b23)
-73063f5002612c6bf64fe24f851cd5cc0d83eef9 ext/rapidjson
-7472c903ec771c00af9925097e8d37075e9a379f ffmpeg
-d02ba7407050f445edf9e908374ad4bf3b2f237b pspautotests
$ git archive-all --ignore-uninitialized-submodules --prefix=ppsspp-1.7.5/ ppsspp-1.7.5.tar.gz
[Errno 2] No such file or directory: '/home/akien/Mageia/Checkout/ppsspp/ppsspp/pspautotests/pspautotests'

So still the same error as in #60.

@akien-mga
Copy link

The --exclude option does seem to work on the other hand:

$ git archive-all --exclude dx9sdk --exclude ext/rapidjson --exclude ffmpeg --exclude pspautotests --prefix=ppsspp-1.7.5/ ppsspp-1.7.5.tar.gz
$ ls -l ppsspp-1.7.5.tar.gz 
-rw-r--r-- 1 akien akien 25045639 Dec 12 09:04 ppsspp-1.7.5.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants