-
-
Notifications
You must be signed in to change notification settings - Fork 36
Optimization #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization #58
Conversation
LOL |
this shit is literally pointless |
exit() and sys.exit cannot stop threads. if someone' program is threaded it wont fully exit |
adding hinting is also pointless |
if it was that important then I would have added it a long time ago |
oh and btw you broke the script |
And you are the guy who asks 20$/h for coding help lmao, you dont even know anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pointless
Replacing the os._exit(1) to exit() is not a good idea
os._exit(1) will stop the program even if it's threaded, sys.exit and exit() will not close the app
Hinting
As I said hinting is pointless wont speed up or slow down the code, nothing gonna change
Deleting the session
?? Whats the point of that, that breaks the whole script lmao
all the requests are using that one session
Deny, I expected something better than this from a guy who asks 20$/h for coding
also this doesnt require any skill I can tell you just used vsc or pycharm to auto add the hints and stuff
❌ |
Your starting a new session every time u use that function. wow this is getting screenshot your basically telling me you dont know python without saying it 🤦 |
Where |
Where is the function |
Type hinting added, removed useless if && replaced useless code