Skip to content

Optimization #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

StructuredObjects
Copy link

Type hinting added, removed useless if && replaced useless code

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

LOL

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

this shit is literally pointless

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

image
what was the point of that?

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

Replacing the os._exit(1) to exit() is just stupid
image

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

exit() and sys.exit cannot stop threads. if someone' program is threaded it wont fully exit

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

adding hinting is also pointless

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

if it was that important then I would have added it a long time ago

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

oh and btw you broke the script

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

all the outgoing requests are using 1 session which u removed for no reason
image

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

here:
image

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

And you are the guy who asks 20$/h for coding help lmao, you dont even know anything

Copy link
Contributor

@6nz 6nz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointless

???
image

Replacing the os._exit(1) to exit() is not a good idea

os._exit(1) will stop the program even if it's threaded, sys.exit and exit() will not close the app
image

Hinting

As I said hinting is pointless wont speed up or slow down the code, nothing gonna change

Deleting the session

?? Whats the point of that, that breaks the whole script lmao

image
image
all the requests are using that one session

Deny, I expected something better than this from a guy who asks 20$/h for coding

also this doesnt require any skill I can tell you just used vsc or pycharm to auto add the hints and stuff

@6nz
Copy link
Contributor

6nz commented Feb 16, 2023

@6nz 6nz closed this Feb 16, 2023
@StructuredObjects
Copy link
Author

StructuredObjects commented Feb 17, 2023

Your starting a new session every time u use that function. wow this is getting screenshot

your basically telling me you dont know python without saying it 🤦

@6nz
Copy link
Contributor

6nz commented Feb 17, 2023

Where

@6nz
Copy link
Contributor

6nz commented Feb 17, 2023

image

@6nz
Copy link
Contributor

6nz commented Feb 17, 2023

Where is the function

@6nz
Copy link
Contributor

6nz commented Feb 17, 2023

image
Unknown kid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants