-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Interactive Graph] New Axes type for graph markings. #2053
Conversation
Size Change: +114 B (+0.01%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (a6f6631) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2053 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2053 |
...erseus-editor/src/widgets/interactive-graph-editor/components/interactive-graph-settings.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good! I think we should probably have a visual test for the axes
option, in interactive-graph-regression.stories.ts
.
Writing that test will probably involve updating interactive-graph-question-builder.ts
as well, which currently has hardcoded "grid" | "graph" | "none"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the updates.
Don't forget to review and accept the snapshot test changes on Chromatic (via the link in the build status) :)
Summary:
At request from content creators they would like to have a new marking type for graph that will show the axes without requiring a full grid.
Issue: LEMS-2713
Test plan:
Go to: http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-linear or any other graph editor.
Select
Axes
option and notice new axes graph markings.