-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle all legacy English content in the Perseus parser #2073
Merged
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
c6307c6
Default PerseusMeasurerWidgetOptions.static to false
benchristel 3af5044
Add TODO comments
benchristel fcf7e74
Default PerseusCategorizerWidgetOptions.randomizeItems to false
benchristel 28c4c5f
Default PerseusExpressionWidgetOptions.buttonSets
benchristel 5e808c1
Default PerseusNumberLineWidgetOptions.static
benchristel 943ae5f
Add note
benchristel 68c572f
Parse deprecated 'simulator' widgets
benchristel be75b0c
Handle matrices with null values in answer
benchristel bcf9578
Default categorizer values to 0
benchristel 3129bed
Default grapher coords
benchristel c796a37
Fix lint
benchristel f7eec3f
Default dropdown placeholder
benchristel 7cb4386
Allow false values for PerseusNumericInputAnswer.simplify
benchristel 7c09e8d
Default PerseusNumericInputWidgetOptions.coefficient to false
benchristel 14116fb
Allow null values for number line correctX
benchristel c75489e
Parse deprecated transformer widget
benchristel 82bc0c7
Rename AutoCorrectWidget to DeprecatedStandinWidget
benchristel 2623860
Default CS program static to false
benchristel 6efd986
Default passage footnotes and title
benchristel 3803084
Tolerate empty strings in number line labelRange
benchristel 6f1bfef
Generate snapshots
benchristel 262909a
Fix lint
benchristel ed4551c
Default label image static to false
benchristel 58868be
Allow 'exact' as a match value for polygon graphs
benchristel 5679ea6
Allow graded group with hint = false
benchristel 5867861
Update snapshots
benchristel 46d4bb0
Fix lint
benchristel 1370bce
Allow answerForms[i].key to be null in expression widget
benchristel 8f6e86b
Refactor
benchristel 6e52ffa
Use the major version number in the data as the source of truth when …
benchristel 0ed6a8a
docs(changeset): Internal: improve the error messages produced by the…
benchristel c3ccccd
docs(changeset): Internal: improve Perseus JSON parsers so they can h…
benchristel 950a278
Update snapshots
benchristel 37449fe
Remove outdated snapshot
benchristel ecef24b
Convert null values in matrix widget answers to NaN
benchristel f6b707b
Update snapshot
benchristel 462ca87
Fix test failure after rebasing
benchristel 14f0079
Add TODO comments
benchristel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we can. These types were originally generated by iterating over our
en
content and deriving TypeScript types from them. I suspectstatic
shows up in these widget options due to bugs that existed for some amount of time in our editors but have since been fixed (or not).