-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove object, context property and message property from perseus strings #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (f854bfc) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2076 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2076 |
Size Change: -404 B (-0.03%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
nishasy
approved these changes
Jan 8, 2025
Merged
anakaren-rojas
pushed a commit
that referenced
this pull request
Jan 8, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#2057](#2057) [`2dc22def4`](2dc22de) Thanks [@dependabot](https://github.com/apps/dependabot)! - update wonderblocks dependencies ## @khanacademy/[email protected] ### Patch Changes - [#2057](#2057) [`2dc22def4`](2dc22de) Thanks [@dependabot](https://github.com/apps/dependabot)! - update wonderblocks dependencies - [#2076](#2076) [`92a741701`](92a7417) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - removes context and message properties from IG perseus strings - Updated dependencies \[[`2dc22def4`](2dc22de)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2057](#2057) [`2dc22def4`](2dc22de) Thanks [@dependabot](https://github.com/apps/dependabot)! - update wonderblocks dependencies - Updated dependencies \[[`2dc22def4`](2dc22de), [`92a741701`](92a7417)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2057](#2057) [`2dc22def4`](2dc22de) Thanks [@dependabot](https://github.com/apps/dependabot)! - update wonderblocks dependencies - Updated dependencies \[[`2dc22def4`](2dc22de)]: - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: anakaren-rojas Required Reviewers: Approved By: anakaren-rojas Checks: ⏭️ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x) Pull Request URL: #2084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates the interactive graph perseus strings - removes the object, context and message properties. Keeps strings
Issue: XXX-XXXX
Test plan:
yarn test