-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the exhaustive test tool for parsePerseusItem to test articles. #2077
Conversation
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (9141024) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2077 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2077 |
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
packages/perseus/src/util/parse-perseus-json/exhaustive-test-tool/index.ts
Outdated
Show resolved
Hide resolved
21757b4
to
362cd15
Compare
} | ||
interface ContentItemTester { | ||
readonly rawData: unknown; | ||
getMismatches(): Mismatch[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure what the superclass / hypernym of "article" and "assessment item" is, so I went with "content item". Not sure if that's right or if there's a better term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content Item feels like a good choice! :)
This will help us find data issues where article content contains invalid or
strangely-shaped Perseus data.
Issue: LEMS-2582
Test plan:
Run the exhaustive test tool on a content snapshot that includes articles.
You should get 14 errors: