Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix perseus-core export #2093

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix perseus-core export #2093

merged 2 commits into from
Jan 10, 2025

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Jan 10, 2025

Summary:

During this PR my IDE mistakenly updated perseus/index.ts when it shouldn't have. These things were moved to perseus-core and shouldn't be exported from perseus.

Issue: LEMS-2737

@handeyeco handeyeco self-assigned this Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (33a2764) and published it to npm. You
can install it using the tag PR2093.

Example:

yarn add @khanacademy/perseus@PR2093

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2093

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Size Change: -29 B (0%)

Total Size: 1.45 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 689 kB -1 B (0%)
packages/perseus/dist/es/index.js 410 kB -28 B (-0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 83.1 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 4.01 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus-score/dist/es/index.js 103 kB
packages/perseus/dist/es/strings.js 4.82 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@handeyeco handeyeco requested review from a team January 10, 2025 20:36
@handeyeco handeyeco merged commit 766d335 into main Jan 10, 2025
8 checks passed
@handeyeco handeyeco deleted the fix-perseus-core-export branch January 10, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants