[LEMS-2563] Primary widget splitter

[handeyeco]

Summary:

Create a central place to pass in a PerseusItem and return a version with all the widget options split of answer data.

Mostly tests and some moving of logic. The main important thing is splitPerseusItem.

Issue: LEMS-2563

Test plan:

This just adds the logic, still not using it. Just unit tests right now.

[github-actions]

Size Change: +29 B (0%)

Total Size: 1.47 MB

Filename	Size	Change
packages/perseus-core/dist/es/index.js	46.8 kB	+399 B (+0.86%)
packages/perseus/dist/es/index.js	368 kB	-370 B (-0.1%)

ℹ️ View Unchanged

Filename	Size
packages/kas/dist/es/index.js	39 kB
packages/keypad-context/dist/es/index.js	760 B
packages/kmath/dist/es/index.js	86.9 kB
packages/math-input/dist/es/index.js	77.7 kB
packages/math-input/dist/es/strings.js	1.79 kB
packages/perseus-editor/dist/es/index.js	689 kB
packages/perseus-linter/dist/es/index.js	22.2 kB
packages/perseus-score/dist/es/index.js	115 kB
packages/perseus/dist/es/strings.js	6.57 kB
packages/pure-markdown/dist/es/index.js	3.66 kB
packages/simple-markdown/dist/es/index.js	12.5 kB

_{compressed-size-action}

[benchristel]

Looks good! I left a few non-blocking suggestions inline.

[benchristel]

If we did this:

Suggested change

	item.widgets = splitWidgets;
	return item;
	return {...item, widgets: splitWidgets};

we wouldn't need to clone above. It might also be clearer what parts of item are being changed.

[handeyeco]

I kind of did a middle ground on this, returning an object literal to make it easier to read but I'm still cloning the object because I'm paranoid.

[benchristel]

Should this function be called splitPerseusRenderer? Or perhaps getRendererPublicData for consistency with the get*PublicWidgetOptions functions?

Suggested change

	export default function splitPerseusItem(
	export default function getRendererPublicData(

[handeyeco]

I did splitPerseusItem to be consistent with scorePerseusItem and validatePerseusItem. If it's all the same to you, I think I'll keep it as-is. As an aside, I think both Renderer and PublicData are misnomers.

• PerseusRenderer isn't a renderer, it's an object that describes an article/exercise that's passed to a renderer. Most of Webapp calls it item or itemData which is a little better IMO but also a little more vague.
• Both the full data and PublicOptions are public data, they're just public at different times. I think StrippedData or AnswerlessData would be more appropriate, but they both have their own issues.

[github-actions]

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (38893c8) and published it to npm. You
can install it using the tag PR2234.

Example:

yarn add @khanacademy/perseus@PR2234

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2234