-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXT_animation_map extension proposal #1137
Open
msfeldstein
wants to merge
16
commits into
KhronosGroup:main
Choose a base branch
from
msfeldstein:ext_animation_map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
730df4e
Add EXT_animation_map extension spec
msfeldstein 2bb65b0
EXT -> FB
msfeldstein 6a022ac
Clarify animation play type
msfeldstein 5cf7dba
serial->sequential
msfeldstein 09ea0c8
Specify Nodes for interactive animations
msfeldstein cfa2bf7
node->nodes, specify that any node can trigger
msfeldstein 24901c3
Update to specify that it can be any nodes triggering
msfeldstein d7a5a25
number --> integer
msfeldstein 04f7005
Add unique items and min items
msfeldstein 211dd1d
Use EXT_ instead of FB_
msfeldstein 087a563
Add pointer semantics
msfeldstein 800e38d
Update README.md
msfeldstein 551b19d
Update the semantics/nodes binding wording
bb1e9fb
Update the semantics/nodes binding wording
d7761f8
formalize semantic names
955ec8b
Add glTF property schemas to animation map schema
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
node->nodes, specify that any node can trigger
- Loading branch information
commit cfa2bf76b0bb28b9d80bc180f1f60082ccf87e36
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,8 +15,16 @@ | |
"type": "number", | ||
"minimum": 0 | ||
} | ||
}, | ||
"nodes": { | ||
"type": "array", | ||
"items": { | ||
"type": "number", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
"minimum": 0 | ||
} | ||
} | ||
} | ||
}, | ||
"required": ["semantic", "animations"] | ||
} | ||
}, | ||
"properties" : { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
number
->integer