Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KHR_light_punctual schema from json schema draft 04 to json schema draft 2020-12 #2379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

teddemunnik
Copy link
Contributor

@teddemunnik teddemunnik commented Apr 2, 2024

As discussed in #2049. This PR does the update just for the KHR_lights_punctual extension.

@@ -51,8 +52,7 @@
"range": {
"type": "number",
"description": "A distance cutoff at which the light's intensity may be considered to have reached zero.",
"minimum": 0,
"exclusiveMinimum": true
"exclusiveMinimum": 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Since this value is not restricted to integers, I would prefer 0.0 instead of just 0, to make it clear to readers. This would also be consistent with other values.

Same for light.spot.schema.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants