Use HTMLElement as root instead of id

closes jaredreich#10, closes jaredreich#40
Kingwl · Jul 15, 2017 · 5d4441d · 5d4441d
1 parent 7164e66
commit 5d4441d
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -122,21 +122,25 @@ window.pell
 
 ```js
 pell.init({
+ // actions: Array<string | Object>
  actions: [
  'bold',
  { name: 'italic', icon: '&#9786;', title: 'Zitalic' },
  'underline'
  ],
+ // classes: Array<string>
  classes: {
  actionbar: 'pell-actionbar',
  button: 'pell-button',
  editor: 'pell-editor'
  },
+ // onChange: Function
  onChange: html => {
  document.getElementById('text-output').innerHTML = html
  document.getElementById('html-output').textContent = html
  },
- root: 'pell'
+ // root: HTMLElement
+ root: document.getElementById('pell')
 })
 ```
 

diff --git a/demo.html b/demo.html
@@ -61,7 +61,7 @@ <h3>HTML output:</h3>
  document.getElementById('text-output').innerHTML = html
  document.getElementById('html-output').textContent = html
  },
- root: 'pell'
+ root: document.getElementById('pell')
  })
  </script>
 

diff --git a/dist/pell.js b/dist/pell.js
@@ -156,19 +156,17 @@ var init = function init(settings) {
 
  settings.classes = _extends({}, defaultSettings.classes, settings.classes);
 
- var root = document.getElementById(settings.root);
-
  var actionbar = document.createElement('div');
  actionbar.className = settings.classes.actionbar;
- root.appendChild(actionbar);
+ settings.root.appendChild(actionbar);
 
  var editor = document.createElement('div');
  editor.contentEditable = true;
  editor.className = settings.classes.editor;
  editor.oninput = function (event) {
  return settings.onChange && settings.onChange(event.target.innerHTML);
  };
- root.appendChild(editor);
+ settings.root.appendChild(editor);
 
  settings.actions.forEach(function (action) {
  var button = document.createElement('button');

diff --git a/dist/pell.min.js b/dist/pell.min.js
diff --git a/src/pell.js b/src/pell.js
@@ -115,17 +115,15 @@ export const init = settings => {
 
  settings.classes = { ...defaultSettings.classes, ...settings.classes }
 
- const root = document.getElementById(settings.root)
-
  const actionbar = document.createElement('div')
  actionbar.className = settings.classes.actionbar
- root.appendChild(actionbar)
+ settings.root.appendChild(actionbar)
 
  const editor = document.createElement('div')
  editor.contentEditable = true
  editor.className = settings.classes.editor
  editor.oninput = event => settings.onChange && settings.onChange(event.target.innerHTML)
- root.appendChild(editor)
+ settings.root.appendChild(editor)
 
  settings.actions.forEach(action => {
  const button = document.createElement('button')