Some fixes on test suite (#655)

.github/workflows/ci.yml

@@ -13,7 +13,7 @@ jobs:
 
     steps:
       - name: Set up PHP
-        uses: shivammathur/setup-php@2.1.0
+        uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
           coverage: none
@@ -55,7 +55,7 @@ jobs:
 
     steps:
       - name: Set up PHP
-        uses: shivammathur/setup-php@2.1.0
+        uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.run.php }}
           coverage: none

spec/Gaufrette/Adapter/GridFSSpec.php

@@ -20,7 +20,9 @@ function let(Bucket $bucket)
     function letGo()
     {
         array_map(function ($res) {
-            @fclose($res);
+            if (is_resource($res)) {
+                @fclose($res);
+            }
         }, $this->resources);
     }
 

src/Gaufrette/Adapter/AsyncAwsS3.php

@@ -71,7 +71,7 @@ public function setMetadata($key, $content)
      */
     public function getMetadata($key)
     {
-        return isset($this->metadata[$key]) ? $this->metadata[$key] : [];
+        return $this->metadata[$key] ?? [];
     }
 
     /**

src/Gaufrette/Adapter/AwsS3.php

@@ -70,7 +70,7 @@ public function setMetadata($key, $metadata)
      */
     public function getMetadata($key)
     {
-        return isset($this->metadata[$key]) ? $this->metadata[$key] : [];
+        return $this->metadata[$key] ?? [];
     }
 
     /**

src/Gaufrette/Adapter/GoogleCloudStorage.php

@@ -328,7 +328,7 @@ public function getMetadata($key)
     {
         $path = $this->computePath($key);
 
-        return isset($this->metadata[$path]) ? $this->metadata[$path] : [];
+        return $this->metadata[$path] ?? [];
     }
 
     /**

src/Gaufrette/Adapter/InMemory.php

@@ -116,7 +116,7 @@ public function keys()
      */
     public function mtime($key)
     {
-        return isset($this->files[$key]['mtime']) ? $this->files[$key]['mtime'] : false;
+        return $this->files[$key]['mtime'] ?? false;
     }
 
     /**

src/Gaufrette/StreamWrapper.php

@@ -254,7 +254,7 @@ protected function createStream($path)
         );
 
         $domain = $parts['host'];
-        $key = substr($parts['path'], 1);
+        $key = !empty($parts['path']) ? substr($parts['path'], 1) : '';
 
         if (null !== $parts['query']) {
             $key .= '?' . $parts['query'];