From Ewelink : Add Dooya Curtain,Reax Curtain and AK Curtain. #8510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Dec 23, 2024
src/lib/ewelink.ts
Outdated
| @@ -31,6 +722,108 @@ export const ewelinkModernExtend = { | |||
| voltageReportingConfig: {min: 3600, max: 7200, change: 10}, | |||
| }); | |||
| }, | |||
| ewelinkWindowCovering(args: WindowCoveringArgs): ModernExtend { | |||
| args = {stateSource: 'lift', configureReporting: true, ...args}; | |||
There was a problem hiding this comment.
Could you call the windowCovering modernExtend here and extend based on that instead of duplicating all the code?
Koenkk
reviewed
Dec 23, 2024
src/lib/ewelink.ts
Outdated
| const ea = access; | ||
|
|
||
| // ====================== Type Or Interface ============================== | ||
| interface WindowCoveringArgs { |
There was a problem hiding this comment.
Please extend the existing WindowCoveringArgs
Koenkk
reviewed
Dec 23, 2024
src/lib/ewelink.ts
Outdated
|
|
||
| // ======================= Custom FZ ===================================== | ||
| export const ewelinkFromZigbee = { | ||
| cover_position_tilt: { |
There was a problem hiding this comment.
Could you also prevent code duplication here?
There was a problem hiding this comment.
Thank you for the review. We will modify the code, complete the testing, and resubmit it
|
Hello, I have reused the windowCovering modernExtend as per your request. Please review it again. |
|
Thanks! Could you also submit a picture for the docs? This can be done by:
Make sure that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I am an employee at EweiLink. This is my first time submitting a PR for ZHC, and the purpose is to familiarize myself with the entire PR process for smoother collaboration in the future. If the PR is successfully approved, I will synchronize all devices currently supported by the two manufacturers, Ewelink and Sonoff, to ZHC！！
features:
All the above features are successfully running on our gateway based on Z2M！！