Is loading #316
Open
Is loading #316
+81
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Revisiting this now, it may make sense to add; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #208
Comments:
isLoading = falseare not covered by tests. They follow analogical lines forisValidating. I only found a test case for one of them (the second changed line) and I am not sure whetherisLoadingis relevant there - if so, pls let me know I will try to extend the test case. The other twoisValidating = falsehowever do not break any tests when commented out. All these three lines are is a separate (second) commit.(Note: this is a second PR for #208. The first one (#284) has been created against the former
nextbranch.)