Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-port the Apple lock (without the Apple-specific qos parts) to other Posix platforms. #517

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

stefanhaustein
Copy link

This should be equivalent to the kmp-compose-core implementation with an added pool, allowing kmp-compose-core to use this implementation and to drop their own

…texNode to a separate file and rename enter/exit to lock/unlock
…her posix platforms. This should be equivalent to the kmp-compose-core implementation with an added pool, allowing kmp-compose-core to use this implementation and to drop their own
@qwwdfsad qwwdfsad self-requested a review February 20, 2025 12:59
@qwwdfsad
Copy link
Collaborator

The build failed, could you please take a look?

@stefanhaustein
Copy link
Author

stefanhaustein commented Feb 20, 2025

The build failed, could you please take a look?

e: ❌ Deprecated Gradle Property 'kotlin.mpp.enableOptimisticNumberCommonization' Used
The `kotlin.mpp.enableOptimisticNumberCommonization` deprecated property is used in your build.
Solutions:
 • It is unsupported, please stop using it.
 • See https://kotl.in/KT-75161 for details.
e: ❌ Deprecated Gradle Property 'kotlin.mpp.enableOptimisticNumberCommonization' Used
The `kotlin.mpp.enableOptimisticNumberCommonization` deprecated property is used in your build.
Solutions:
 • It is unsupported, please stop using it.
 • See https://kotl.in/KT-75161 for details.
Task ':atomicfu:checkKotlinGradlePluginConfigurationErrors' is not up-to-date because:
  Task has not declared any outputs despite executing actions.
org.gradle.tooling.internal.consumer.DefaultFailure: Kotlin Gradle Plugin reported errors. Check the log for details

Could the strictness of "something" have been increased in the meantime?
Are you sure this doesn't happen at head?

I have no idea what these mean or how they could be related....

@mvicsokolova
Copy link
Collaborator

I've removed the property kotlin.mpp.enableOptimisticNumberCommonization from the TC configuration of Kotlin master build, as it's no longer needed.

Restarted the build ⌛

@mvicsokolova
Copy link
Collaborator

Now rebasing this branch onto the fresh develop should fix the Kotlin master build

@stefanhaustein
Copy link
Author

stefanhaustein commented Feb 25, 2025

Thanks! I think I did so now... Can you re-trigger the build (if it's not done automatically)?

@fzhinkin
Copy link
Contributor

As a safety measure CI requires manual triggering for PRs opened by external (non-JB) users.
For some reason, the CI doesn't see the merge commit yet, I'll double check it later today.

@fzhinkin
Copy link
Contributor

As a safety measure CI requires manual triggering for PRs opened by external (non-JB) users.

Ok, I see, for AFU the reason is slightly different. :)
The build is now running.

@stefanhaustein
Copy link
Author

I have updated the pull request to address #520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants