Allow URL-encoded spaces in generated HTML #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After generating the HTML with xmlgen, the HTML is passed to `format` as a format string. However, “%” is not an uncommon character in HTML, most commonly with “%20” for URL-encoded spaces. `format` would complain when it encountered these. This is a workaround to specifically get `format` to ignore `%20`. A more general solution would be better, but this fixes my immediate issue of entries having spaces in their names. This also wraps the “Error during parsing of entry text” message in a `<p>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After generating the HTML with xmlgen, the HTML is passed to
formatas aformat string. However, “%” is not an uncommon character in HTML, most commonly
with “%20” for URL-encoded spaces.
formatwould complain when it encounteredthese.
This is a workaround to specifically get
formatto ignore%20. A moregeneral solution would be better, but this fixes my immediate issue of entries
having spaces in their names.
This also wraps the “Error during parsing of entry text” message in a
<p>.