Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Acoustic, Electro Library #25

Closed
wants to merge 25 commits into from
Closed

Adding Acoustic, Electro Library #25

wants to merge 25 commits into from

Conversation

SirBothersome
Copy link
Contributor

@SirBothersome SirBothersome commented Aug 3, 2016

So here it is, twenty or so acoustic samples from @unfa and me. I've tested them with a focus group to make sure that they are of good quality. If it so pleases the court, I can post an archive of the library was well if you want to listen to them yourself. For my next act, I shall try making EDM drum samples.
I may add some toms at a later date if I can get some good samples, bu as of now, I am leaving them out.

This is just a test
Removed outdated author references
added unfa's sites to authors file
Making sure all of unfa's info got put in
This is about 30% of the samples library. Hope to add more soon
Lots of samples. could use some toms perhaps, but I don't think it's a
neccessity.
<deficio/at/live/dot/se>
Riser samples
Antonio "SirBothersome" Alberto
<https://Soundcloud.com/mrlmmsguy>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove home page urls and soundcloud urls.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and replace with email addresses and ifyou'd like github @handles.

@tresf
Copy link
Member

tresf commented Aug 3, 2016

These need to be consistently named. (spacing, case)

e.g. NOT File 1.flac and My Sound2.flac and SomeSample1.flac and anothersample.flac

@tresf
Copy link
Member

tresf commented Aug 3, 2016

Main sample pack/Acoustic/fingersnap1.flac

@SirBothersome
Copy link
Contributor Author

@tresf, fixed the lowercasing, anything else I missed?

For my next act, I shall try making EDM drum samples.

I wonder if @StakeoutPunch would want to help...

@tresf
Copy link
Member

tresf commented Aug 8, 2016

"Clang Clap" "FingerSnap" still inconsistent.

@SirBothersome
Copy link
Contributor Author

Curses... lemme fix that

On Mon, Aug 8, 2016 at 11:55 AM, Tres Finocchiaro [email protected]
wrote:

"Clang Clap" "FingerSnap" still inconsistent.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#25 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ATZmp8iSYCMAhcBNWfEB5scfb8by8_Ztks5qd1FtgaJpZM4JbQfI
.

@tresf
Copy link
Member

tresf commented Aug 9, 2016

why space chirp.flac not match? Why Crash1 but Clap no number?

@SirBothersome
Copy link
Contributor Author

why space chirp.flac not match? Why Crash1 but Clap no number?

I'm going to delete the space chirp actually... And since there was only one clap clap, I didn't see a neeed to add a number

@tresf
Copy link
Member

tresf commented Aug 9, 2016

There's only one crash too, so I'm not sure your point.

@tresf
Copy link
Member

tresf commented Aug 10, 2016

space chirp.flac is still lowercase.

@tresf
Copy link
Member

tresf commented Aug 10, 2016

Inside the flac file, why did you list yourself as the author of Unfa's work?

Also, are you Antonio Alberto, SirBothersome or Mayo Staccato ?

I'm sick of these aliases. Unless you have a great reason to hide behind an alias, just put people's names, or clobber them all with LMMS Developers

'Cause Hindsight is 20/20
@SirBothersome
Copy link
Contributor Author

SirBothersome commented Aug 12, 2016

Oh, yes you did.

Oh, I see. I added myself to the authors list because I processed and eq'd the samples. I'm not trying to whine here, but I dug through 2+ Gigabytes of raw source audio, which I then derived individual samples from, processed, made sure to trim every bit of silence off of the beginning of each sample, and then altered according to peer review response, so I felt that I contributed to the samples.

So this PR is finally ready for review

Yay! I hope this makes the next release.

@tresf
Copy link
Member

tresf commented Aug 12, 2016

Oh, I see. I added myself to the authors list because I processed and eq'd the samples.

If they're CC0 it doesn't really matter, but if this were a book, the editor doesn't get to put his name on the cover.

I dug through 2+ Gigabytes of raw source audio

It's part of the gig. This software is a lot of work. If the samples were easy to do, they would have been done already. I've seen people spend months of hard work on a single bug and still not have it merged, so let's just proceed with what benefits the project and not start weighing our personal investments.

Yay! I hope this makes the next release.

No, it will not. (unless the other admins believe otherwise of course)

@SirBothersome
Copy link
Contributor Author

SirBothersome commented Aug 12, 2016

If they're CC0 it doesn't really matter, but if this were a book, the editor doesn't get to put his name on the cover.
It's part of the gig. This software is a lot of work. If the samples were easy to do, they would have been done already. I've seen people spend months of hard work on a single bug and still not have it merged, so let's just proceed with what benefits the project and not start weighing our personal investments.

Artistic arguments aside, it now says "LMMS Developers" in the metadata. A much better idea than watermarking every single one with the name of the content maker(s). Kudos to you

No, it will not. (unless the other admins believe otherwise of course)

Out of curiosity, what would have to be done to have it ship with 1.2 in your opinion? I've made some decent progress with the electronic drum samples, and I don't think retrofitting and trimming the demo library will take very long

@tresf
Copy link
Member

tresf commented Aug 12, 2016

what would have to be done to have it ship with 1.2 in your opinion?

Well, we have to decide when we cut off the old sample library and roll out the new sample library right? Or is this proposal meant to be in-addition-to the current library? e.g. Ok you added some samples, but does that make them the new samples?

You tell us. What do we do with 27 new sample files? Do people that download LMMS allow old projects to break because the sample pack was swapped out without notice?

@SirBothersome
Copy link
Contributor Author

SirBothersome commented Aug 12, 2016

Well, we have to decide when we cut off the old sample library and roll out the new sample library right? Or is this proposal meant to be in-addition-to the current library? e.g. Ok you added some samples, but does that make them the new samples?
You tell us. What do we do with 27 new sample files? Do people that download LMMS allow old projects to break because the sample pack was swapped out without notice?

@tresf, I was making these with the intention of them replacing the old samples, (part of the reason I posted #24 ) I wanted there to be no shadow of doubt as to LMMS' reputation and also, people have been complaining about the samples for a while now, it seems.

Do people that download LMMS allow old projects to break because the sample pack was swapped out without notice?

Chances are, we're going to arrive at a point where there's going to have to be some sweeping change, and not everybody will be happy. While an announcement could be added to the LSP and the forum, all things considered, retrofitting is not that hard, and I doubt the old samples will be missed

@tresf
Copy link
Member

tresf commented Aug 12, 2016

retrofitting is not that hard, and I doubt the old samples will be missed

From observation, people do use the base samples projects. The LSP is full of 'em, so this statement is incorrect.

I was making these with the intention of them replacing the old samples

We all want that. We may want a house to replace our current house, but that doesn't mean you push the old one out with a bulldozer without proper warning.

@SirBothersome
Copy link
Contributor Author

SirBothersome commented Aug 12, 2016

but that doesn't mean you push the old one out with a bulldozer without proper warning.

Hrmm... At any rate, merging this won't change LMMS's master. Also there are projects that don't have native samples, so the "emptyness" effect is probably not new to LSPers. I think putting an announcement in LSP about the upcoming "data apocalypse" should do the trick. I'm going poll my focus group on this.

@tresf
Copy link
Member

tresf commented Aug 12, 2016

Also there are projects that don't have native samples, so the "emptyness" effect probably is probably not new to LSPers

Then how the **** would you play it? This conversation is going nowhere. This pack needs to be reviewed, that's the next step. It won't make the 1.2 release unless YOU HELP PLAN it. We don't do that with a club, we do that with a gentle hand. We have 500,000 users to worry about. Don't be naive, it helps no one..

@SirBothersome
Copy link
Contributor Author

SirBothersome commented Aug 19, 2016

It won't make the 1.2 release unless YOU HELP PLAN it.

Okay, so far, the two best options for the release (IMO) are these:

  1. Expunge the library, but offer the legacy sounds in a separate download.
    Pros: Easy, minimal setup required,
    Cons: Plenty of room for operator error,
    Also, this really depends how certain devel is of whether or not our legacy library is correctly licensed. If the general consensus is that it is not correctly licensed, it would hardly seem ethical or wise to distribute the legacy samples with that knowledge.
  2. code an exception routine that loads upon detecting project files made by legacy distros. eg. (pardon my pseudocode)
    ` - if (kick.ogg == false)
  • load "SimilarKick.flac"[filepath/filepath];
  • continue; //like a switch statement methinks, I forget the proper command for this one
  • if (snaremuffled.ogg == false)
  • load "BetterSnare.flac"[filepath/filepath];
  • ...
  • break;
  • FX = true
  • return "YAY_SAMPLESLOADED";`

pros: clean, requires no extra download or user action.
cons: probably wouldn't cover all 1000+ samples, more work for devel
probably not worth the effort, as it would likely occupy some 400+ lines of code

These are the best two options I can think of at the moment (though the download was my pal's idea, and I think it's been suggested before)

@tresf
Copy link
Member

tresf commented Aug 19, 2016

it would likely occupy some 400+ lines of code

Do you feel 200+ samples we include now should all be replaced with these 25 you've chosen?

@SirBothersome
Copy link
Contributor Author

No! this is the "Acoustic Library"

On Fri, Aug 19, 2016 at 2:32 PM, Tres Finocchiaro [email protected]
wrote:

it would likely occupy some 400+ lines of code

Do you feel 200+ samples we include now should all be replaced with these
25 you've chosen?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#25 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ATZmp6KIkrOEER96-qnIh1ezKDQnvIBHks5qhfbZgaJpZM4JbQfI
.

@tresf
Copy link
Member

tresf commented Aug 19, 2016

Where do you suggest we put it exactly?

https://github.com/LMMS/lmms/tree/master/data/samples

How do we keep track of it to know it's part of our new CC0 library initiative?

@SirBothersome
Copy link
Contributor Author

How do we keep track of it to know it's part of our new CC0 library initiative?

Well, for one thing, these are all flacs. Unless I'm seriously misunderstanding something, I thought this current repo was serving as a holding point for the new samples until integration could be reached

@tresf
Copy link
Member

tresf commented Aug 19, 2016

I thought this current repo was serving as a holding point for the new samples until integration could be reached

Exactly, and since 1.2 integration was brought up, it's being discussed.

@SirBothersome
Copy link
Contributor Author

SirBothersome commented Aug 19, 2016

Where do you suggest we put it exactly?

Well if we do put it with lmms/data, we could just uppercase the new folders to differentiate them

Thought the Acoustic Library could use a little more variety
@SirBothersome
Copy link
Contributor Author

Surprise! I'm not dead. I've made some new samples, and have some more in the pipeline. @tresf , just let me know if I need to stop it already. Oh, and I got rid of the Mhak Kicks, I don't think they were legally cleared, and believe that not many of you liked them

@SirBothersome
Copy link
Contributor Author

SirBothersome commented Oct 6, 2016

Oh, and I got rid of the Mhak Kicks, I don't think they were legally cleared, and believe that not many of you liked them

Which is hindsight ain't that terrific of an idea... assuming new samples are even considered a priority
@zonkmachine, @tobydox @tresf @StakeoutPunch @Spekular.... Does anyone have any inclination to review this?

@SirBothersome SirBothersome changed the title Adding Acoustic Library Adding Acoustic, Electro Library Oct 6, 2016
for consistensy reasons.
For continuity purposes. That is, if anybody is actually paying
attention
@SirBothersome
Copy link
Contributor Author

SirBothersome commented Dec 15, 2016

Sooo, I put the Mhak kicks back. And... Oh, not much else. @tresf Last update was August 30, but apparently, nobody has taken it upon themselves to look at it, or even comment. ;-;
Which makes progress rather difficult

'Cuz they sound better now
@SirBothersome
Copy link
Contributor Author

Closing. This PR has gone rather stale, and I think integrating individual libraries will be more efficient at this point. I've also committed this all on my master, which is a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants