-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Acoustic, Electro Library #25
Conversation
This is just a test
Removed outdated author references
This is about 30% of the samples library. Hope to add more soon
Lots of samples. could use some toms perhaps, but I don't think it's a neccessity.
<deficio/at/live/dot/se> | ||
Riser samples | ||
Antonio "SirBothersome" Alberto | ||
<https://Soundcloud.com/mrlmmsguy> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove home page urls and soundcloud urls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and replace with email addresses and ifyou'd like github @handles
.
These need to be consistently named. (spacing, case) e.g. NOT |
|
@tresf, fixed the lowercasing, anything else I missed?
I wonder if @StakeoutPunch would want to help... |
"Clang Clap" "FingerSnap" still inconsistent. |
Curses... lemme fix that On Mon, Aug 8, 2016 at 11:55 AM, Tres Finocchiaro [email protected]
|
why |
I'm going to delete the space chirp actually... And since there was only one clap clap, I didn't see a neeed to add a number |
There's only one crash too, so I'm not sure your point. |
|
Inside the flac file, why did you list yourself as the author of Unfa's work? Also, are you I'm sick of these aliases. Unless you have a great reason to hide behind an alias, just put people's names, or clobber them all with |
'Cause Hindsight is 20/20
Oh, I see. I added myself to the authors list because I processed and eq'd the samples. I'm not trying to whine here, but I dug through 2+ Gigabytes of raw source audio, which I then derived individual samples from, processed, made sure to trim every bit of silence off of the beginning of each sample, and then altered according to peer review response, so I felt that I contributed to the samples.
Yay! I hope this makes the next release. |
If they're CC0 it doesn't really matter, but if this were a book, the editor doesn't get to put his name on the cover.
It's part of the gig. This software is a lot of work. If the samples were easy to do, they would have been done already. I've seen people spend months of hard work on a single bug and still not have it merged, so let's just proceed with what benefits the project and not start weighing our personal investments.
No, it will not. (unless the other admins believe otherwise of course) |
Artistic arguments aside, it now says "LMMS Developers" in the metadata. A much better idea than watermarking every single one with the name of the content maker(s). Kudos to you
Out of curiosity, what would have to be done to have it ship with 1.2 in your opinion? I've made some decent progress with the electronic drum samples, and I don't think retrofitting and trimming the demo library will take very long |
Well, we have to decide when we cut off the old sample library and roll out the new sample library right? Or is this proposal meant to be in-addition-to the current library? e.g. Ok you added some samples, but does that make them the new samples? You tell us. What do we do with 27 new sample files? Do people that download LMMS allow old projects to break because the sample pack was swapped out without notice? |
@tresf, I was making these with the intention of them replacing the old samples, (part of the reason I posted #24 ) I wanted there to be no shadow of doubt as to LMMS' reputation and also, people have been complaining about the samples for a while now, it seems.
Chances are, we're going to arrive at a point where there's going to have to be some sweeping change, and not everybody will be happy. While an announcement could be added to the LSP and the forum, all things considered, retrofitting is not that hard, and I doubt the old samples will be missed |
From observation, people do use the base samples projects. The LSP is full of 'em, so this statement is incorrect.
We all want that. We may want a house to replace our current house, but that doesn't mean you push the old one out with a bulldozer without proper warning. |
Hrmm... At any rate, merging this won't change LMMS's master. Also there are projects that don't have native samples, so the "emptyness" effect is probably not new to LSPers. I think putting an announcement in LSP about the upcoming "data apocalypse" should do the trick. I'm going poll my focus group on this. |
Then how the **** would you play it? This conversation is going nowhere. This pack needs to be reviewed, that's the next step. It won't make the 1.2 release unless YOU HELP PLAN it. We don't do that with a club, we do that with a gentle hand. We have 500,000 users to worry about. Don't be naive, it helps no one.. |
Okay, so far, the two best options for the release (IMO) are these:
pros: clean, requires no extra download or user action. These are the best two options I can think of at the moment (though the download was my pal's idea, and I think it's been suggested before) |
Do you feel 200+ samples we include now should all be replaced with these 25 you've chosen? |
No! this is the "Acoustic Library" On Fri, Aug 19, 2016 at 2:32 PM, Tres Finocchiaro [email protected]
|
Where do you suggest we put it exactly? https://github.com/LMMS/lmms/tree/master/data/samples How do we keep track of it to know it's part of our new CC0 library initiative? |
Well, for one thing, these are all flacs. Unless I'm seriously misunderstanding something, I thought this current repo was serving as a holding point for the new samples until integration could be reached |
Exactly, and since 1.2 integration was brought up, it's being discussed. |
Well if we do put it with lmms/data, we could just uppercase the new folders to differentiate them |
Thought the Acoustic Library could use a little more variety
Surprise! I'm not dead. I've made some new samples, and have some more in the pipeline. @tresf , just let me know if I need to stop it already. Oh, and I got rid of the Mhak Kicks, I don't think they were legally cleared, and believe that not many of you liked them |
Which is hindsight ain't that terrific of an idea... assuming new samples are even considered a priority |
for consistensy reasons.
For continuity purposes. That is, if anybody is actually paying attention
Sooo, I put the Mhak kicks back. And... Oh, not much else. @tresf Last update was August 30, but apparently, nobody has taken it upon themselves to look at it, or even comment. ;-; |
'Cuz they sound better now
Closing. This PR has gone rather stale, and I think integrating individual libraries will be more efficient at this point. I've also committed this all on my master, which is a problem |
So here it is, twenty or so acoustic samples from @unfa and me. I've tested them with a focus group to make sure that they are of good quality. If it so pleases the court, I can post an archive of the library was well if you want to listen to them yourself. For my next act, I shall try making EDM drum samples.
I may add some toms at a later date if I can get some good samples, bu as of now, I am leaving them out.