Improve ExecuteSql endpoint wrapper #1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2025
cnathe
approved these changes
Jun 24, 2025
packages/components/src/internal/components/domainproperties/dataset/actions.ts
Outdated
Show resolved
Hide resolved
| @@ -777,7 +773,7 @@ export function getCrossFolderSelectionResult( | |||
|
|
|||
| return new Promise((resolve, reject) => { | |||
| return Ajax.request({ | |||
| url: buildURL('experiment', 'getCrossFolderDataSelection.api'), | |||
| url: ActionURL.buildURL('experiment', 'getCrossFolderDataSelection.api'), | |||
There was a problem hiding this comment.
just curious: is there a specific reason for moving these to ActionURL.buildURL? should we be deprecating or removing the buildURL in ui-components?
There was a problem hiding this comment.
When linking to LKS I recommend using ActionURL.buildURL() as it was purpose-built for that. The other buildURL() still has utility but mainly just for it's support generation of navigation links where we are linking from within the apps to LKS pages (which is not very often) for user navigation purposes. We could rename the latter but I don't think we should deprecate it since there is not 100% functional overlap.
labkey-nicka
force-pushed
the
fb_execute_sql
branch
from
c0270e4 to
9b99ef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Introduce a standalone
executeSql()that is akin toselectRows(). We have a number of usages ofQuery.executeSql()that are not going through our wrappers (namelyselectRowsDeprecated()). This streamlines all of the executeSql calls, gets rid of the awkward patterns inselectRowsDeprecated(), and allows for reduction of a lot of boilerplate.Related Pull Requests
Changes
executeSql()and adds it to ourQueryAPIWrapper.Query.executeSql()in our apps to use the newexecuteSql().selectRowsDeprecated()that are using the sql parameter to useexecuteSql().Query.executeSql()fromselectRowsDeprecated().selectRowsDeprecated()(better late then never).Query.Commandinterface