Issue 53120: remove processRequest, use getCallbackWrapper #1814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnathe
approved these changes
Jun 24, 2025
labkey-nicka
force-pushed
the
fb_request_53120
branch
from
d34d2f4 to
e2c5a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses Issue 53120 by removing the client-side redundant processing of request payloads and deferring to the commonly used
Utils.getCallbackWrapper().Related Pull Requests
Changes
processRequest()that was handling the scenario where the content did not match the content type (e.g. a JSON payload where the content-type header is html or something else).reports-browseDataTree.apiendpoint wrapper to not perform its own JSON parsing and usegetCallbackWrapper()instead.