Skip to content

Issue 53326: Don't filter QuerySelect in PrintLabelsModal #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 27, 2025

Conversation

labkey-susanh
Copy link
Contributor

@labkey-susanh labkey-susanh commented Jun 26, 2025

Rationale

Issue 53326: The QuerySelect input for the Print Labels modal does not need or want to be filtered based on the grid it is associated with. If filtered, some of the selected samples may not be available since we don't retrieve all columns for that QuerySelect.

Related Pull Requests

Changes

  • Remove queryFilter parameter from QuerySelect in PrintLabelsModal
  • Add a defensive check that assures the sorts value for QueryInfo is defined.

@labkey-susanh labkey-susanh requested a review from cnathe June 26, 2025 14:34
@labkey-susanh labkey-susanh merged commit 43e0e90 into develop Jun 27, 2025
3 checks passed
@labkey-susanh labkey-susanh deleted the fb_miscIssues257seh branch June 27, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants