Skip to content

Issue 53091: Don't include calculated aliquot rollup columns in audit details #6819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

labkey-susanh
Copy link
Contributor

@labkey-susanh labkey-susanh commented Jul 2, 2025

Rationale

Issue 53091

Related Pull Requests

Changes

  • Update SampleTimelineAuditEvent.setOldRecordMap and SampleTimelineAuditEvent.setNewRecordMap to exclude the aliquot rollup calculated fields from the audit details.

Tasks 📍

  • Manual Testing @XingY
  • Needs Automation
  • Verify Fix

@labkey-susanh labkey-susanh requested a review from XingY July 2, 2025 22:10
@labkey-susanh labkey-susanh self-assigned this Jul 2, 2025
@labkey-susanh labkey-susanh changed the title Issue 53091: Don't include calculate aliquot rollup columns in audit details Issue 53091: Don't include calculated aliquot rollup columns in audit details Jul 2, 2025
Copy link
Contributor

@XingY XingY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AliquotUnit as well?

@labkey-susanh
Copy link
Contributor Author

AliquotUnit as well?

Yes, good thought. This didn't show up in my testing scenarios, but perhaps I didn't fiddle with units enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants