Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibURL+LibWeb+UI: Remove the implicit URL constructors #3668

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

LibURL+LibWeb+UI: Remove the implicit URL constructors #3668

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7a68bae
LibWeb/HTML: Make HTMLImageRequests currentURL a String
shannonbooth Feb 22, 2025
77294ac
LibWebView: Handle missing URL for view source
shannonbooth Feb 22, 2025
56f7895
LibWeb/HTML: Explicitly basic parse URL when following the hyperlink
shannonbooth Feb 22, 2025
ed2bc11
LibWeb/HTML: Parse URL track URL before creating fetch request
shannonbooth Feb 22, 2025
3add0f0
LibWeb/Loader: Explicitly parse URL generating directory response
shannonbooth Feb 22, 2025
9e91615
UI/AppKit: Do not rely on the implicit URL constructors
shannonbooth Feb 22, 2025
3d40038
UI/Qt: Do not rely on the URL implicit constructors
shannonbooth Feb 22, 2025
389b512
Meta: Use URL basic parse for URL Fuzzer
shannonbooth Feb 22, 2025
cbf0ac8
LibURL: Remove the implicit URL constructors
shannonbooth Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
LibWeb/Loader: Explicitly parse URL generating directory response 
Removing one more caller of the implicit URL constructors.
  • Loading branch information
@shannonbooth
shannonbooth committed Feb 22, 2025
commit 3add0f091532b70bce18ed32a0a3a30109455ccf
6 changes: 5 additions & 1 deletion Libraries/LibWeb/Loader/ResourceLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@
#include <LibCore/Directory.h>
#include <LibCore/MimeData.h>
#include <LibCore/Resource.h>
#include <LibGC/Function.h>
#include <LibHTTP/HttpResponse.h>
#include <LibRequests/Request.h>
#include <LibRequests/RequestClient.h>
#include <LibURL/Parser.h>
#include <LibWeb/Cookie/Cookie.h>
#include <LibWeb/Cookie/ParsedCookie.h>
#include <LibWeb/Fetch/Infrastructure/URL.h>
Expand Down Expand Up @@ -320,7 +322,9 @@ void ResourceLoader::load(LoadRequest& request, GC::Root<SuccessCallback> succes

// When resource URI is a directory use file directory loader to generate response
if (resource.value()->is_directory()) {
respond_directory_page(request, resource.value()->file_url(), success_callback, error_callback);
auto url = URL::Parser::basic_parse(resource.value()->file_url());
VERIFY(url.has_value());
Comment on lines +325 to +326
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this a bunch makes me wonder if we should just have an explicit infallible URL parser

respond_directory_page(request, url.release_value(), success_callback, error_callback);
return;
}

Expand Down