Implement HTMLFormElement::checkValidity and all HTMLInputElement “suffering from being missing” constraints (client-side form validation) #3674
+369
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
changed the title
sideshowbarker
force-pushed
the
client-side-form-validation
branch
from
97ee7be to
fbb15a0
Compare
This change implements the requirements from the HTML spec at https://html.spec.whatwg.org/#statically-validate-the-constraints and https://html.spec.whatwg.org/#dom-form-checkvalidity — the parts of the HTML constraint validation API (aka “client-side form validation”) https://html.spec.whatwg.org/#the-constraint-validation-api for HTMLFormElement itself — as well as the code for the requirements at https://html.spec.whatwg.org/#check-validity-steps, which are the shared requirements for the checkValidity method for individual form controls.
sideshowbarker
force-pushed
the
client-side-form-validation
branch
from
fbb15a0 to
8833b0d
Compare
This change implements all required “suffering from being missing” constraints https://html.spec.whatwg.org/#suffering-from-being-missing for HTMLInputElement.
sideshowbarker
force-pushed
the
client-side-form-validation
branch
from
8833b0d to
915934f
Compare
tcl3
reviewed
Feb 24, 2025
| @@ -561,11 +561,49 @@ unsigned HTMLFormElement::length() const | |||
| return elements()->length(); | |||
| } | |||
|
|
|||
| // https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#statically-validate-the-constraints | |||
| HTMLFormElement::StaticValidationResult HTMLFormElement::statically_validate_contraints() | |||
Comment on lines
+573
to
+574
| VERIFY(is<FormAssociatedElement>(*element)); | ||
| auto& field = dynamic_cast<FormAssociatedElement&>(*element); |
There was a problem hiding this comment.
These 2 lines can be simplified to auto& field = as<FormAssociatedElement>(*element);
| @@ -2525,8 +2525,7 @@ WebIDL::ExceptionOr<void> HTMLInputElement::step_up_or_down(bool is_down, WebIDL | |||
| // https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#dom-cva-checkvalidity | |||
| WebIDL::ExceptionOr<bool> HTMLInputElement::check_validity() | |||
| { | |||
| dbgln("(STUBBED) HTMLInputElement::check_validity(). Called on: {}", debug_description()); | |||
| return true; | |||
| return dynamic_cast<FormAssociatedElement&>(*this).check_validity(); | |||
There was a problem hiding this comment.
If this method gets renamed, the cast should become unnecessary.
| @@ -226,6 +226,20 @@ WebIDL::ExceptionOr<void> FormAssociatedElement::set_form_action(String const& v | |||
| return html_element.set_attribute(HTML::AttributeNames::formaction, value); | |||
| } | |||
|
|
|||
| // https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#check-validity-steps | |||
| WebIDL::ExceptionOr<bool> FormAssociatedElement::check_validity() | |||
There was a problem hiding this comment.
It might be better to rename this method to check_validity_steps() to avoid the method being hidden. This would also match the name used in the spec.
I don't think there's any need for this to return ExceptionOr since there's no way it can error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some core parts of the HTML “constraint-validation API” (aka “client-side form validation”):
formelement itself: theHTMLFormElement::checkValiditymethodcheckValiditymethod for individual form controlsThe PR also implements all “suffering from being missing” constraints for
HTMLInputElement.This change gets us a number of new passes for some of the 130 subtests of the test at https://wpt.fyi/results/html/semantics/forms/constraints/form-validation-checkValidity.html?product=ladybird. We should be able to get to passing 100% of those subtests in subsequent PRs that fill out the remaining constraint checks from that spec (and that are already stubbed out in the code, from a previous PR).